Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2127853002: Disable Quick View by default and add about flag to enable it. (Closed)

Created:
4 years, 5 months ago by oka
Modified:
4 years, 5 months ago
Reviewers:
rkaplow, fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Quick View by default and add about flag to enable it. Set --enable-files-quick-view to enable quick view. BUG=613465 TEST=manually using link. Committed: https://crrev.com/0a9c9cdd253d3b0963b7676166bd612cdab7838a Cr-Commit-Position: refs/heads/master@{#404617}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 2 chunks +4 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
oka
PTAL.
4 years, 5 months ago (2016-07-06 14:30:47 UTC) #2
fukino
https://codereview.chromium.org/2127853002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2127853002/diff/1/chrome/app/generated_resources.grd#newcode15090 chrome/app/generated_resources.grd:15090: + <if expr="chromeos"> Please use chrome/app/chromeos_strings.grd
4 years, 5 months ago (2016-07-07 06:37:49 UTC) #4
oka
Address comment.
4 years, 5 months ago (2016-07-07 10:32:50 UTC) #5
oka
PTAL. https://codereview.chromium.org/2127853002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2127853002/diff/1/chrome/app/generated_resources.grd#newcode15090 chrome/app/generated_resources.grd:15090: + <if expr="chromeos"> On 2016/07/07 06:37:49, fukino wrote: ...
4 years, 5 months ago (2016-07-07 10:34:04 UTC) #6
fukino
lgtm. Please get approval for histograms.xml
4 years, 5 months ago (2016-07-07 10:53:12 UTC) #7
oka
rkaplow@ PTAL for histograms.xml.
4 years, 5 months ago (2016-07-07 11:34:59 UTC) #9
oka
On 2016/07/07 11:34:59, oka wrote: > rkaplow@ PTAL for histograms.xml. rkaplow@ Friendly ping.
4 years, 5 months ago (2016-07-08 05:01:11 UTC) #10
oka
On 2016/07/07 11:34:59, oka wrote: > rkaplow@ PTAL for histograms.xml. rkaplow@ Friendly ping.
4 years, 5 months ago (2016-07-08 05:01:14 UTC) #11
oka
On 2016/07/07 11:34:59, oka wrote: > rkaplow@ PTAL for histograms.xml. rkaplow@ Friendly ping.
4 years, 5 months ago (2016-07-08 05:01:15 UTC) #12
rkaplow
lgtm histogram lg
4 years, 5 months ago (2016-07-08 14:32:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127853002/20001
4 years, 5 months ago (2016-07-11 07:38:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 08:45:36 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:47:12 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0a9c9cdd253d3b0963b7676166bd612cdab7838a
Cr-Commit-Position: refs/heads/master@{#404617}

Powered by Google App Engine
This is Rietveld 408576698