Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2178073003: cc: Use setter methods on layer instead of SetLayerPropertiesForTesting (Closed)

Created:
4 years, 5 months ago by danakj
Modified:
4 years, 5 months ago
Reviewers:
jaydasika, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Use setter methods on layer instead of SetLayerPropertiesForTesting This changes half the LayerTreeHostCommon tests to just set things on layers instead of calling SetLayerPropertiesForTesting with a bunch of default values that are just noise. Once the others are done we can remove those methods. R=ajuma@chromium.org, jaydasika@chromium.org BUG=630754 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/e4fa7b739871b8f04b8a72abbe4e4933bb21e1e3 Cr-Commit-Position: refs/heads/master@{#407608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+922 lines, -1508 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 124 chunks +922 lines, -1508 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
danakj
I feel like this actually makes the tests more clear too. It's easier to tell ...
4 years, 5 months ago (2016-07-25 21:01:09 UTC) #2
jaydasika
lgtm
4 years, 5 months ago (2016-07-25 21:53:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178073003/1
4 years, 5 months ago (2016-07-25 21:56:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 22:00:21 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 22:02:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4fa7b739871b8f04b8a72abbe4e4933bb21e1e3
Cr-Commit-Position: refs/heads/master@{#407608}

Powered by Google App Engine
This is Rietveld 408576698