Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2178053002: Change RequestFinishedListener to provide executor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add more tests, other comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
index fd13de1b7f0d002fea46abca29b1e4ae8cb02e72..4ae1f97e8914517d74345cebec4bcc2c6210498e 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
@@ -492,16 +492,15 @@ public final class CronetUrlRequest implements UrlRequest {
////////////////////////////////////////////////
/**
- * Called before following redirects. The redirect will automatically be
- * followed, unless the request is paused or canceled during this
- * callback. If the redirect response has a body, it will be ignored.
+ * Called before following redirects. The redirect will only be followed if
+ * {@link #followRedirect()} is called. If the redirect response has a body, it will be ignored.
* This will only be called between start and onResponseStarted.
*
* @param newLocation Location where request is redirected.
* @param httpStatusCode from redirect response
* @param receivedBytesCount count of bytes received for redirect response
- * @param headers an array of response headers with keys at the even indices
- * followed by the corresponding values at the odd indices.
+ * @param headers an array of response headers with keys at the even indices followed by the
xunjieli 2016/07/29 16:35:24 Why is this line changed? Could you revert?
mgersh 2016/07/29 18:21:52 Done.
+ * corresponding values at the odd indices.
*/
@SuppressWarnings("unused")
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698