components/cronet/android/api/src/org/chromium/net/UrlRequest.java - Issue 2178053002: Change RequestFinishedListener to provide executor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/UrlRequest.java

Issue 2178053002: Change RequestFinishedListener to provide executor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add more tests, other comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/api/src/org/chromium/net/UrlRequest.java

diff --git a/components/cronet/android/api/src/org/chromium/net/UrlRequest.java b/components/cronet/android/api/src/org/chromium/net/UrlRequest.java

index 2b2957c2ab1ba60162d685e7735abc246cd176bc..7d4999050d19162f45349b22cb07a3ad7c94d587 100644

--- a/components/cronet/android/api/src/org/chromium/net/UrlRequest.java

+++ b/components/cronet/android/api/src/org/chromium/net/UrlRequest.java

@@ -228,11 +228,11 @@ public interface UrlRequest {

/**

* Associates the annotation object with this request. May add more than one.

- * Passed through to a {@link CronetEngine.RequestFinishedListener},

+ * Passed through to a {@link RequestFinishedListener},

* see {@link CronetEngine.UrlRequestInfo#getAnnotations}.

- * @param annotation an object to pass on to the

- * {@link CronetEngine.RequestFinishedListener} with a {@link CronetEngine.UrlRequestInfo}.

+ * @param annotation an object to pass on to the {@link RequestFinishedListener} with a

+ * {@link CronetEngine.UrlRequestInfo}.

* @return the builder to facilitate chaining.

* @hide as it's a prototype.