Make CallbackHelper#waitUntilCriteria verbose during failure.

Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122
Committed: https://crrev.com/6c632b3764ed4fc351eded015dbc95caeecd932c
Cr-Commit-Position: refs/heads/master@{#412708}

[bhallam, 2016-07-25 17:40:58]

Description was changed from

==========
Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=i631122
==========

to

==========
Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122
==========

[bhallam, 2016-07-25 17:40:59]

bhallam@amazon.com changed reviewers:
+ miguelg@chromium.org

[bhallam, 2016-07-26 23:42:06]

Hi Miguel,
Can you PTAL at this patch.

Thanks!
Mohit

[bhallam, 2016-08-16 20:24:18]

bhallam@amazon.com changed reviewers:
+ tedchoc@chromium.org
- miguelg@chromium.org

[bhallam, 2016-08-17 01:05:50]

Hi Ted!
Can you PTAL at this patch?

Thanks
Mohit

[Ted C, 2016-08-17 14:26:38]

https://codereview.chromium.org/2178023002/diff/20001/content/public/test/and...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java
(right):

https://codereview.chromium.org/2178023002/diff/20001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java:219:
final String message = TextUtils.isEmpty(criteria.getFailureReason())
getFailureReason is default populated with "Criteria not met in allotted time.",
so I think this isEmpty check is unnecessary.

https://codereview.chromium.org/2178023002/diff/20001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java:224:
if (!isSatisfied) throw new TimeoutException(message);
since message is only used in this conditional, let's move it inside of here to
avoid the allocation otherwise.

[bhallam, 2016-08-17 16:59:01]

Hi Ted,
I have updated the CL.

Thanks
Mohit

https://codereview.chromium.org/2178023002/diff/20001/content/public/test/and...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java
(right):

https://codereview.chromium.org/2178023002/diff/20001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java:219:
final String message = TextUtils.isEmpty(criteria.getFailureReason())
On 2016/08/17 14:26:38, Ted C wrote:
> getFailureReason is default populated with "Criteria not met in allotted
time.",
> so I think this isEmpty check is unnecessary.

That makes sense.. Thanks!

https://codereview.chromium.org/2178023002/diff/20001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java:224:
if (!isSatisfied) throw new TimeoutException(message);
On 2016/08/17 14:26:38, Ted C wrote:
> since message is only used in this conditional, let's move it inside of here
to
> avoid the allocation otherwise.

Done.

[bhallam, 2016-08-17 16:59:22]

The CQ bit was checked by bhallam@amazon.com

[bhallam, 2016-08-17 16:59:23]

The CQ bit was unchecked by bhallam@amazon.com

[Ted C, 2016-08-17 22:59:12]

lgtm

[bhallam, 2016-08-17 23:16:36]

The CQ bit was checked by bhallam@amazon.com

[commit-bot: I haz the power, 2016-08-17 23:17:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 00:48:53]

Description was changed from

==========
Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122
==========

to

==========
Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122
==========

[commit-bot: I haz the power, 2016-08-18 00:48:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-18 00:52:05]

Description was changed from

==========
Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122
==========

to

==========
Make CallbackHelper#waitUntilCriteria verbose during failure.

Currently the implementation of
CallbackHelper#waitUntilCriteria(Criteria, long, TimeUnit)
takes in a Criteria which has a failure message which is never surfaced up
when the waitUntilCriteria call times out.

This change will utilize the failure message whenever
the Criteria object contains a non null failure message.

BUG=631122

Committed: https://crrev.com/6c632b3764ed4fc351eded015dbc95caeecd932c
Cr-Commit-Position: refs/heads/master@{#412708}
==========

[commit-bot: I haz the power, 2016-08-18 00:52:06]

Patchset 3 (id:??) landed as
https://crrev.com/6c632b3764ed4fc351eded015dbc95caeecd932c
Cr-Commit-Position: refs/heads/master@{#412708}