Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java

Issue 2178023002: Make CallbackHelper#waitUntilCriteria verbose during failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing TedC's comment on failure message redundant null check. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java
diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java
index e3537e847f05c9d9c43504069f75b42e01452df9..c1e91ec8a2a2eb41d4d8e849cfd6a05e574b1900 100644
--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java
+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java
@@ -214,7 +214,8 @@ public class CallbackHelper {
mLock.wait(unit.toMillis(timeout));
isSatisfied = criteria.isSatisfied();
}
- if (!isSatisfied) throw new TimeoutException("waitUntilCriteria timed out!");
+
+ if (!isSatisfied) throw new TimeoutException(criteria.getFailureReason());
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698