Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: content/shell/browser/layout_test/layout_test_devtools_frontend.h

Issue 2177983004: [DevTools] Do not use "settings" query param. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_ 5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_
6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_ 6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "content/shell/browser/shell_devtools_frontend.h" 10 #include "content/shell/browser/shell_devtools_frontend.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 class RenderViewHost; 14 class RenderViewHost;
15 class Shell; 15 class Shell;
16 class WebContents; 16 class WebContents;
17 17
18 class LayoutTestDevToolsFrontend : public ShellDevToolsFrontend { 18 class LayoutTestDevToolsFrontend : public ShellDevToolsFrontend {
19 public: 19 public:
20 static LayoutTestDevToolsFrontend* Show(WebContents* inspected_contents, 20 static LayoutTestDevToolsFrontend* Show(WebContents* inspected_contents,
21 const std::string& settings, 21 const std::string& settings,
22 const std::string& frontend_url); 22 const std::string& frontend_url);
23 23
24 static GURL GetDevToolsPathAsURL(const std::string& settings, 24 static GURL GetDevToolsPathAsURL(const std::string& frontend_url);
25 const std::string& frontend_url);
26 25
27 void ReuseFrontend(const std::string& settings, 26 void ReuseFrontend(const std::string& settings,
28 const std::string frontend_url); 27 const std::string frontend_url);
29 void EvaluateInFrontend(int call_id, const std::string& expression); 28 void EvaluateInFrontend(int call_id, const std::string& expression);
30 29
31 private: 30 private:
32 LayoutTestDevToolsFrontend(Shell* frontend_shell, 31 LayoutTestDevToolsFrontend(Shell* frontend_shell,
33 WebContents* inspected_contents); 32 WebContents* inspected_contents);
34 ~LayoutTestDevToolsFrontend() override; 33 ~LayoutTestDevToolsFrontend() override;
35 34
36 // content::DevToolsAgentHostClient implementation. 35 // content::DevToolsAgentHostClient implementation.
37 void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override; 36 void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override;
38 37
39 // ShellDevToolsFrontend overrides. 38 // ShellDevToolsFrontend overrides.
40 void HandleMessageFromDevToolsFrontend(const std::string& message) override; 39 void HandleMessageFromDevToolsFrontend(const std::string& message) override;
41 40
42 // WebContentsObserver implementation. 41 // WebContentsObserver implementation.
43 void RenderProcessGone(base::TerminationStatus status) override; 42 void RenderProcessGone(base::TerminationStatus status) override;
44 void RenderFrameCreated(RenderFrameHost* render_frame_host) override; 43 void RenderFrameCreated(RenderFrameHost* render_frame_host) override;
45 44
46 bool ready_for_test_; 45 bool ready_for_test_;
47 std::vector<std::pair<int, std::string>> pending_evaluations_; 46 std::vector<std::pair<int, std::string>> pending_evaluations_;
48 47
49 DISALLOW_COPY_AND_ASSIGN(LayoutTestDevToolsFrontend); 48 DISALLOW_COPY_AND_ASSIGN(LayoutTestDevToolsFrontend);
50 }; 49 };
51 50
52 } // namespace content 51 } // namespace content
53 52
54 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_ 53 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698