Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2177943005: Move user requested trigger conditions into policy object. (Closed)

Created:
4 years, 5 months ago by Pete Williamson
Modified:
4 years, 4 months ago
Reviewers:
dougarnett, fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move user requested trigger conditions into policy object. BUG=610521 Committed: https://crrev.com/27343245fe66080ccb85226189ce6a567e8171c1 Cr-Commit-Position: refs/heads/master@{#407902}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make more methods const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M components/offline_pages/background/offliner_policy.h View 1 1 chunk +19 lines, -4 lines 0 comments Download
M components/offline_pages/background/request_coordinator.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Pete Williamson
4 years, 5 months ago (2016-07-25 21:49:34 UTC) #2
dougarnett
lgtm
4 years, 4 months ago (2016-07-26 16:29:45 UTC) #3
fgorski
lgtm with a comment. https://codereview.chromium.org/2177943005/diff/1/components/offline_pages/background/offliner_policy.h File components/offline_pages/background/offliner_policy.h (right): https://codereview.chromium.org/2177943005/diff/1/components/offline_pages/background/offliner_policy.h#newcode41 components/offline_pages/background/offliner_policy.h:41: bool PowerRequiredForUserRequestedPage() { return false; ...
4 years, 4 months ago (2016-07-26 16:42:14 UTC) #4
Pete Williamson
https://codereview.chromium.org/2177943005/diff/1/components/offline_pages/background/offliner_policy.h File components/offline_pages/background/offliner_policy.h (right): https://codereview.chromium.org/2177943005/diff/1/components/offline_pages/background/offliner_policy.h#newcode41 components/offline_pages/background/offliner_policy.h:41: bool PowerRequiredForUserRequestedPage() { return false; } On 2016/07/26 16:42:14, ...
4 years, 4 months ago (2016-07-26 19:39:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177943005/20001
4 years, 4 months ago (2016-07-26 19:40:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 20:33:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:36:29 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/27343245fe66080ccb85226189ce6a567e8171c1
Cr-Commit-Position: refs/heads/master@{#407902}

Powered by Google App Engine
This is Rietveld 408576698