components/offline_pages/background/request_coordinator.h - Issue 2177943005: Move user requested trigger conditions into policy object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2177943005: Move user requested trigger conditions into policy object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make more methods const Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/offliner_policy.h ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.h

diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h

index c4858505aa3ec8c6743513cd8742368fb015ab78..4eaed65f522ba496429f45dc0bbe292ac182f3ce 100644

--- a/components/offline_pages/background/request_coordinator.h

+++ b/components/offline_pages/background/request_coordinator.h

@@ -62,8 +62,7 @@ class RequestCoordinator : public KeyedService {

// is stopped or complete.

void StopProcessing();

- // TODO(dougarnett): Move to OfflinerPolicy in some form.

- const Scheduler::TriggerConditions& GetTriggerConditionsForUserRequest();

+ const Scheduler::TriggerConditions GetTriggerConditionsForUserRequest();

// A way for tests to set the callback in use when an operation is over.

void SetProcessingCallbackForTest(const base::Callback<void(bool)> callback) {