Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2177863003: net/url_util: fix std::string::assign invocation: pass string instead of char*. (Closed)

Created:
4 years, 4 months ago by krasin
Modified:
4 years, 4 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net/url_util: fix std::string::assign invocation: pass string instead of char*. According to the C++ standard, the three arguments overload of std::string::assign accepts an std::basic_string: http://en.cppreference.com/w/cpp/string/basic_string/assign Fixing the usage, where char* instead of std::string was passed. This popped up after libc++ became more standard compliant, and now it throws a compiler error. BUG=630681 Committed: https://crrev.com/8f2bd296ae050bb16ea552d38375d9fc6760d518 Cr-Commit-Position: refs/heads/master@{#407599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/base/url_util.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
krasin
4 years, 4 months ago (2016-07-25 18:21:45 UTC) #2
mef
lgtm
4 years, 4 months ago (2016-07-25 20:21:50 UTC) #3
krasin
Thank you!
4 years, 4 months ago (2016-07-25 20:44:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177863003/1
4 years, 4 months ago (2016-07-25 20:44:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 21:50:58 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 21:55:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f2bd296ae050bb16ea552d38375d9fc6760d518
Cr-Commit-Position: refs/heads/master@{#407599}

Powered by Google App Engine
This is Rietveld 408576698