net/base/url_util.cc - Issue 2177863003: net/url_util: fix std::string::assign invocation: pass string instead of char*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/url_util.cc

Issue 2177863003: net/url_util: fix std::string::assign invocation: pass string instead of char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/url_util.cc

diff --git a/net/base/url_util.cc b/net/base/url_util.cc

index 879c746c9b3fea7584840034f6c29680f57915c0..8d47bd3be29321d4aca20f0a52bbccfeb812e57f 100644

--- a/net/base/url_util.cc

+++ b/net/base/url_util.cc

@@ -74,8 +74,7 @@ GURL AppendOrReplaceQueryParameter(const GURL& url,

replaced = true;

key_value_pair = (param_name + "=" + param_value);

} else {

- key_value_pair.assign(input.data(),

- key_range.begin,

+ key_value_pair.assign(input, key_range.begin,

value_range.end() - key_range.begin);

}

if (!output.empty())

« no previous file with comments | « no previous file | no next file » | no next file with comments »