Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 2177853002: MacViews: Fix setMarkedText in BridgedContentView to take replacementRange into account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime_regression
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/cocoa/bridged_content_view.mm
diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm
index 39dae81d1ae28dcbc2ee6a4a3e18ebe4e0f6af36..612fc616e6ceccc6417657969fa126dac50efa16 100644
--- a/ui/views/cocoa/bridged_content_view.mm
+++ b/ui/views/cocoa/bridged_content_view.mm
@@ -1221,6 +1221,8 @@ - (void)setMarkedText:(id)text
if ([text isKindOfClass:[NSAttributedString class]])
text = [text string];
+
+ textInputClient_->DeleteRange(gfx::Range(replacementRange));
karandeepb 2016/07/26 03:40:52 The only case I have found where a valid replaceme
tapted 2016/07/26 05:40:27 I don't really know IME code paths TBH. One guess:
ui::CompositionText composition;
composition.text = base::SysNSStringToUTF16(text);
composition.selection = gfx::Range(selectedRange);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698