MacViews: Fix setMarkedText in BridgedContentView to take replacementRange into account.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 1203 matching lines @@
 }
 
 - (void)setMarkedText:(id)text
         selectedRange:(NSRange)selectedRange
      replacementRange:(NSRange)replacementRange {
   if (!textInputClient_)
     return;
 
   if ([text isKindOfClass:[NSAttributedString class]])
     text = [text string];
+
+  textInputClient_->DeleteRange(gfx::Range(replacementRange));

[karandeepb, 2016/07/26 03:40:52]

The only case I have found where a valid replacementRange is being passed is
when accented characters are input. Do you know of any other possible case?
Asking because apple docs for the method say  "replacementRange:The range to
replace, computed from the beginning of the marked text." which seems slightly
incorrect, since replacementRange seems to be computed from the beginning of the
text not only marked/composed text.

[tapted, 2016/07/26 05:40:27]

I don't really know IME code paths TBH. One guess: maybe when tabbing through
choices in the IME input window?

   ui::CompositionText composition;
   composition.text = base::SysNSStringToUTF16(text);
   composition.selection = gfx::Range(selectedRange);
   textInputClient_->SetCompositionText(composition);
 }
 
 - (void)unmarkText {
   if (textInputClient_)
     textInputClient_->ConfirmCompositionText();
 }
@@ skipping 54 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end