[Cronet] Add test to verify that PUT and empty buffer for last write work.

[Cronet] Add test to verify that PUT and empty buffer for last write work on iOS.

BUG=623988
Committed: https://crrev.com/b757230ce4c51eb73bf951abfd363318c7416246
Cr-Commit-Position: refs/heads/master@{#407892}

[mef, 2016-07-22 19:34:18]

Description was changed from

==========
[Cronet] Add test to verify that PUT and empty buffer for last write work.

BUG=
==========

to

==========
[Cronet] Add test to verify that PUT and empty buffer for last write work on
iOS.

BUG=623988
==========

[mef, 2016-07-22 19:34:18]

mef@chromium.org changed reviewers:
+ xunjieli@chromium.org

[mef, 2016-07-22 19:35:04]

Hi Helen,

PTAL. This is just a small test to verify that last write can be empty.

[xunjieli, 2016-07-25 18:36:43]

LGTM.

https://codereview.chromium.org/2177653002/diff/1/components/cronet/ios/test/...
File components/cronet/ios/test/cronet_bidirectional_stream_test.mm (right):

https://codereview.chromium.org/2177653002/diff/1/components/cronet/ios/test/...
components/cronet/ios/test/cronet_bidirectional_stream_test.mm:334:
test.read_buffer_size = 2;
Could you add a comment on why we are using a read buffer size of 2 bytes?

https://codereview.chromium.org/2177653002/diff/1/components/cronet/ios/test/...
components/cronet/ios/test/cronet_bidirectional_stream_test.mm:348:
ASSERT_EQ(std::string(kHelloBodyValue), base::JoinString(test.read_data, ""));
Why do we need a concatenation of test.read_data with "" here?
I am assuming it is because std::string(kHelloBodyValue) includes the
terminating character \0 ?

If so, can we add a comment? I know other tests are also doing the same.

[mef, 2016-07-26 19:26:25]

Thanks!

https://codereview.chromium.org/2177653002/diff/1/components/cronet/ios/test/...
File components/cronet/ios/test/cronet_bidirectional_stream_test.mm (right):

https://codereview.chromium.org/2177653002/diff/1/components/cronet/ios/test/...
components/cronet/ios/test/cronet_bidirectional_stream_test.mm:334:
test.read_buffer_size = 2;
On 2016/07/25 18:36:43, xunjieli wrote:
> Could you add a comment on why we are using a read buffer size of 2 bytes?

Done. I've added comment to StartExampleBidiStream test, which used small
buffers before and refactored this to use default buffer to test slightly
different code path.

https://codereview.chromium.org/2177653002/diff/1/components/cronet/ios/test/...
components/cronet/ios/test/cronet_bidirectional_stream_test.mm:348:
ASSERT_EQ(std::string(kHelloBodyValue), base::JoinString(test.read_data, ""));
On 2016/07/25 18:36:43, xunjieli wrote:
> Why do we need a concatenation of test.read_data with "" here?
> I am assuming it is because std::string(kHelloBodyValue) includes the
> terminating character \0 ?
The empty string is a separator between elements being joined, so result should
match expected response body.
> 
> If so, can we add a comment? I know other tests are also doing the same.

[mef, 2016-07-26 19:26:49]

The CQ bit was checked by mef@chromium.org

[mef, 2016-07-26 19:26:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2177653002/#ps20001
(title: "Address Helen's comments.")

[commit-bot: I haz the power, 2016-07-26 19:27:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 20:06:11]

Description was changed from

==========
[Cronet] Add test to verify that PUT and empty buffer for last write work on
iOS.

BUG=623988
==========

to

==========
[Cronet] Add test to verify that PUT and empty buffer for last write work on
iOS.

BUG=623988
==========

[commit-bot: I haz the power, 2016-07-26 20:06:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 20:10:25]

Description was changed from

==========
[Cronet] Add test to verify that PUT and empty buffer for last write work on
iOS.

BUG=623988
==========

to

==========
[Cronet] Add test to verify that PUT and empty buffer for last write work on
iOS.

BUG=623988

Committed: https://crrev.com/b757230ce4c51eb73bf951abfd363318c7416246
Cr-Commit-Position: refs/heads/master@{#407892}
==========

[commit-bot: I haz the power, 2016-07-26 20:10:26]

Patchset 2 (id:??) landed as
https://crrev.com/b757230ce4c51eb73bf951abfd363318c7416246
Cr-Commit-Position: refs/heads/master@{#407892}