[Cronet] Add test to verify that PUT and empty buffer for last write work.

components/cronet/ios/test/cronet_bidirectional_stream_test.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 #include <stdint.h>
 #include <list>
 #include <map>
 #include <string>
 
@@ skipping 308 matching lines @@
   ASSERT_EQ(std::string(kHelloHeaderValue),
             test.response_headers[kHelloHeaderName]);
   ASSERT_EQ(TestBidirectionalStreamCallback::ON_SUCCEEDED, test.response_step);
   ASSERT_EQ(std::string(kHelloBodyValue, 2), test.read_data.front());
   ASSERT_EQ(std::string(kHelloBodyValue), base::JoinString(test.read_data, ""));
   ASSERT_EQ(std::string(kHelloTrailerValue),
             test.response_trailers[kHelloTrailerName]);
   cronet_bidirectional_stream_destroy(test.stream);
 }
 
+TEST_P(CronetBidirectionalStreamTest, SimplePutWithEmptyWriteDataAtTheEnd) {
+  TestBidirectionalStreamCallback test;
+  test.AddWriteData("Hello, ");
+  test.AddWriteData("world!");
+  test.AddWriteData("");
+  test.read_buffer_size = 2;

[xunjieli, 2016/07/25 18:36:43]

Could you add a comment on why we are using a read buffer size of 2 bytes?

[mef, 2016/07/26 19:26:24]

Done. I've added comment to StartExampleBidiStream test, which used small
buffers before and refactored this to use default buffer to test slightly
different code path.

+  test.stream =
+      cronet_bidirectional_stream_create(engine(), &test, test.callback());
+  DCHECK(test.stream);
+  cronet_bidirectional_stream_delay_request_headers_until_flush(test.stream,
+                                                                GetParam());
+  cronet_bidirectional_stream_start(test.stream, kTestServerUrl, 0, "PUT",
+                                    &kTestHeadersArray, false);
+  test.BlockForDone();
+  ASSERT_EQ(std::string(kHelloStatus), test.response_headers[kStatusHeader]);
+  ASSERT_EQ(std::string(kHelloHeaderValue),
+            test.response_headers[kHelloHeaderName]);
+  ASSERT_EQ(TestBidirectionalStreamCallback::ON_SUCCEEDED, test.response_step);
+  ASSERT_EQ(std::string(kHelloBodyValue, 2), test.read_data.front());
+  ASSERT_EQ(std::string(kHelloBodyValue), base::JoinString(test.read_data, ""));

[xunjieli, 2016/07/25 18:36:43]

Why do we need a concatenation of test.read_data with "" here?
I am assuming it is because std::string(kHelloBodyValue) includes the
terminating character \0 ?

If so, can we add a comment? I know other tests are also doing the same.

[mef, 2016/07/26 19:26:24]

The empty string is a separator between elements being joined, so result should
match expected response body.

+  ASSERT_EQ(std::string(kHelloTrailerValue),
+            test.response_trailers[kHelloTrailerName]);
+  cronet_bidirectional_stream_destroy(test.stream);
+}
+
 TEST_P(CronetBidirectionalStreamTest, SimpleGetWithFlush) {
   TestBidirectionalStreamCallback test;
   test.stream =
       cronet_bidirectional_stream_create(engine(), &test, test.callback());
   DCHECK(test.stream);
   cronet_bidirectional_stream_disable_auto_flush(test.stream, true);
   cronet_bidirectional_stream_delay_request_headers_until_flush(test.stream,
                                                                 GetParam());
   // Flush before start is ignored.
   cronet_bidirectional_stream_flush(test.stream);
@@ skipping 311 matching lines @@
   ASSERT_EQ(TestBidirectionalStreamCallback::ON_FAILED, test.response_step);
   ASSERT_EQ(net::ERR_NAME_NOT_RESOLVED, test.net_error);
   cronet_bidirectional_stream_destroy(test.stream);
 }
 
 INSTANTIATE_TEST_CASE_P(CronetBidirectionalStreamDelayRequestHeadersUntilFlush,
                         CronetBidirectionalStreamTest,
                         ::testing::Values(true, false));
 
 }  // namespace cronet