Add option to send reboot command and not wait for device.

Add option to send reboot command and not wait for device.

This will be useful for devices that need ssh tunnels to communicate
(i.e. GCE AVDs).

Also implement Reset() in TcpHandle.

Also add a ResetHandle() method to AdbCommands.

BUG=628769
R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=72674a1d640130b13da6d52c23c4e090e979d270

[bpastene, 2016-07-23 00:53:23]

Description was changed from

==========
Add option to send reboot command and not wait for device.

This will be useful for devices that need ssh tunnels to communicate
(i.e. GCE AVDs).

Also implement Reset() in TcpHandle.

BUG=628769
==========

to

==========
Add option to send reboot command and not wait for device.

This will be useful for devices that need ssh tunnels to communicate
(i.e. GCE AVDs).

Also implement Reset() in TcpHandle.

Also add a ResetHandle() method to AdbCommands.

BUG=628769
==========

[bpastene, 2016-07-23 00:55:56]

bpastene@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-07-23 00:58:44]

https://codereview.chromium.org/2177573003/diff/1/adb/common.py
File adb/common.py (right):

https://codereview.chromium.org/2177573003/diff/1/adb/common.py#newcode448
adb/common.py:448: if ':' in new_endpoint:
I feel odd about this, shouldn't we create a new instance instead?

https://codereview.chromium.org/2177573003/diff/1/adb/contrib/adb_commands_sa...
File adb/contrib/adb_commands_safe.py (right):

https://codereview.chromium.org/2177573003/diff/1/adb/contrib/adb_commands_sa...
adb/contrib/adb_commands_safe.py:393: def ResetHandle(self, new_endpoint=None):
Please add a docstring.

[bpastene, 2016-07-23 01:17:39]

https://codereview.chromium.org/2177573003/diff/1/adb/common.py
File adb/common.py (right):

https://codereview.chromium.org/2177573003/diff/1/adb/common.py#newcode448
adb/common.py:448: if ':' in new_endpoint:
On 2016/07/23 00:58:43, M-A Ruel wrote:
> I feel odd about this, shouldn't we create a new instance instead?

Yeah; I tried, but ran into a couple of problems:
- Who does the creating? And how would it know to create a USBHandle vs
TCPHandle?
- For a single device, there are multiple references to that device's handle (in
HighDevice, AdbCommandsSafe, AdbCommands, AdbConnectionManager, etc.) I didn't
feel like hunting down each one. 

Better to let the handle itself do all the changes it needs to, I think. But I'm
willing to go with another approach, if you feel otherwise.

https://codereview.chromium.org/2177573003/diff/1/adb/contrib/adb_commands_sa...
File adb/contrib/adb_commands_safe.py (right):

https://codereview.chromium.org/2177573003/diff/1/adb/contrib/adb_commands_sa...
adb/contrib/adb_commands_safe.py:393: def ResetHandle(self, new_endpoint=None):
On 2016/07/23 00:58:44, M-A Ruel wrote:
> Please add a docstring.

Done.

[M-A Ruel, 2016-07-23 01:29:35]

lgtm

https://codereview.chromium.org/2177573003/diff/1/adb/common.py
File adb/common.py (right):

https://codereview.chromium.org/2177573003/diff/1/adb/common.py#newcode448
adb/common.py:448: if ':' in new_endpoint:
On 2016/07/23 01:17:39, bpastene wrote:
> On 2016/07/23 00:58:43, M-A Ruel wrote:
> > I feel odd about this, shouldn't we create a new instance instead?
> 
> Yeah; I tried, but ran into a couple of problems:
> - Who does the creating? And how would it know to create a USBHandle vs
> TCPHandle?
> - For a single device, there are multiple references to that device's handle
(in
> HighDevice, AdbCommandsSafe, AdbCommands, AdbConnectionManager, etc.) I didn't
> feel like hunting down each one. 
> 
> Better to let the handle itself do all the changes it needs to, I think. But
I'm
> willing to go with another approach, if you feel otherwise.

No, that's fine. Not worth reengineering.

[bpastene, 2016-07-25 18:13:29]

Description was changed from

==========
Add option to send reboot command and not wait for device.

This will be useful for devices that need ssh tunnels to communicate
(i.e. GCE AVDs).

Also implement Reset() in TcpHandle.

Also add a ResetHandle() method to AdbCommands.

BUG=628769
==========

to

==========
Add option to send reboot command and not wait for device.

This will be useful for devices that need ssh tunnels to communicate
(i.e. GCE AVDs).

Also implement Reset() in TcpHandle.

Also add a ResetHandle() method to AdbCommands.

BUG=628769
R=maruel@chromium.org

Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=72674a1d640130b13da6...
==========

[bpastene, 2016-07-25 18:13:31]

Committed patchset #3 (id:40001) manually as
72674a1d640130b13da6d52c23c4e090e979d270 (presubmit successful).