Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2177383006: Update and fix sendBeacon() redirect behavior. (Closed)

Created:
4 years, 4 months ago by sof
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update and fix sendBeacon() redirect behavior. Refresh the implementation to follow the specification changes in https://github.com/w3c/beacon/pull/33 https://github.com/w3c/beacon/pull/34 In particular, correctly flag a CORS-disallowed redirect as not to be followed by WebURLLoader. R= BUG=628762 Committed: https://crrev.com/3fe79278480bcf6aea4172056d5b8beb18aeb5a9 Cr-Commit-Position: refs/heads/master@{#408380}

Patch Set 1 #

Patch Set 2 : comment spelling #

Total comments: 12

Patch Set 3 : improve content type initialization #

Messages

Total messages: 22 (15 generated)
sof
please take a look.
4 years, 4 months ago (2016-07-27 16:06:27 UTC) #5
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/2177383006/diff/20001/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html File third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html (right): https://codereview.chromium.org/2177383006/diff/20001/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html#newcode4 third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html:4: <script src="/js-test-resources/js-test.js"></script> mkwst@ has sent a mail encouraging use ...
4 years, 4 months ago (2016-07-28 07:21:57 UTC) #10
sof
https://codereview.chromium.org/2177383006/diff/20001/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html File third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html (right): https://codereview.chromium.org/2177383006/diff/20001/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html#newcode4 third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html:4: <script src="/js-test-resources/js-test.js"></script> On 2016/07/28 07:21:57, tyoshino wrote: > mkwst@ ...
4 years, 4 months ago (2016-07-28 08:28:20 UTC) #11
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/2177383006/diff/20001/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html File third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html (right): https://codereview.chromium.org/2177383006/diff/20001/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html#newcode4 third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html:4: <script src="/js-test-resources/js-test.js"></script> On 2016/07/28 08:28:19, sof wrote: > ...
4 years, 4 months ago (2016-07-28 12:03:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177383006/40001
4 years, 4 months ago (2016-07-28 13:20:08 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 13:23:02 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 13:24:19 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3fe79278480bcf6aea4172056d5b8beb18aeb5a9
Cr-Commit-Position: refs/heads/master@{#408380}

Powered by Google App Engine
This is Rietveld 408576698