third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html - Issue 2177383006: Update and fix sendBeacon() redirect behavior.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob.html

Issue 2177383006: Update and fix sendBeacon() redirect behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment spelling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-blob-expected.txt » ('j') | third_party/WebKit/Source/core/loader/BeaconLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <script src="/js-test-resources/js-test.js"></script>
	tyoshino (SeeGerritForStatus) 2016/07/28 07:21:57 mkwst@ has sent a mail encouraging use of testharn mkwst@ has sent a mail encouraging use of testharness.js for new tests and there were basically no objection. Shall we follow that? https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/testharne... https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-... sof 2016/07/28 08:28:19 No, I don't think we should for one beacon test. Show quoted text On 2016/07/28 07:21:57, tyoshino wrote: > mkwst@ has sent a mail encouraging use of testharness.js for new tests and there > were basically no objection. Shall we follow that? > > https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/testharne... > https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-... No, I don't think we should for one beacon test. tyoshino (SeeGerritForStatus) 2016/07/28 12:03:20 For consistency with existing tests? Then, ok. Show quoted text On 2016/07/28 08:28:19, sof wrote: > On 2016/07/28 07:21:57, tyoshino wrote: > > mkwst@ has sent a mail encouraging use of testharness.js for new tests and > there > > were basically no objection. Shall we follow that? > > > > > https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/testharne... > > > https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-... > > No, I don't think we should for one beacon test. For consistency with existing tests? Then, ok.
	5 <script>

	6 description("Verifying navigator.sendBeacon(Blob) non-CORS cross-origin redirect handling.");

	7

	8 window.jsTestIsAsync = true;

	9

	10 var blob;

	11 function test() {

	12 if (window.testRunner) {

	13 testRunner.dumpAsText();

	14 testRunner.dumpPingLoaderCallbacks();

	15 }

	16

	17 blob = new Blob(["Cross", "Origin"], {type: "text/plain;from-beacon=true"});

	18 shouldBeTrue('navigator.sendBeacon("http://127.0.0.1:8080/navigation/resourc es/redirection-response.php?status=302&simple=true&target=non-existent.php", blo b);');

	19 // Wait a while for the redirect response handling to happen before finishin g up.

	20 setTimeout(function () {

	21 blob = new Blob([new Uint8Array(20)], {type: "application/octet-stream"} );

	22 shouldBeTrue('navigator.sendBeacon("http://127.0.0.1:8080/navigation/res ources/redirection-response.php?status=302&simple=false&target=non-existent.php" , blob);');

	23 setTimeout(finishJSTest, 200);

	24 }, 200);

	25 }

	26 </script>

	27 </head>

	28 <body onload="test();">

	29 </body>

	30 </html>

OLD	NEW