Add top level app element

Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

This also moves the elements/stats to elements/imp/stats, which was overlooked in the last CL.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/bc79132b9686e2553be97baef8a74bba547d5354

[kjlubick, 2016-07-25 20:12:03]

Description was changed from

==========
Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

BUG=631047
==========

to

==========
Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

BUG=631047
==========

[kjlubick, 2016-07-25 20:17:31]

Description was changed from

==========
Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

BUG=631047
==========

to

==========
Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

This also moves the elements/stats to elements/imp/stats, which was overlooked
in the last CL.

BUG=631047
==========

[kjlubick, 2016-07-25 20:18:35]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[jcgregorio, 2016-07-26 12:55:09]

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/Makefile (right):

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/Makefile:26: ./node_modules/.bin/vulcanize
--inline-css=true --inline-scripts=true --strip-comments=true
--out-html=./build/index-build.html index.html
Instead of vulcanizing index.html and botlist-index.html individually, there
should be a single file 'elements.html' that lists the top level elements, i.e.
swarming-app, swarming-index that gets vulcanized into a single file
./build/elements.html that gets imported by both index.html and botlist.html.
The advantage is that while the file will be larger, you will only need to
download it once regardless of which page you move to.

It also reduces the number of generated files to be checked into the git repo to
just one, the vulcanized elements.html.

Note that the two index files will need to import the web components polyfill
and then HTML import the elements.html file.

This will also enable 'debug' mode, which can be done in a later CL, which is
where you don't vulcanize elements.html and it just imports all of it's
dependents individually, which is slower, but makes developing and debugging
much easier.

[stephana, 2016-07-26 13:13:00]

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/imp/stats/load-charts-api.html (right):

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/imp/stats/load-charts-api.html:2: # Copyright 2016
The LUCI Authors. All rights reserved.
How does the directory structure relate the apps (index.html and botlist.html) ?

[kjlubick, 2016-07-26 13:28:21]

On 2016/07/26 at 13:13:00, stephana wrote:
>
https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
> File appengine/swarming/elements/imp/stats/load-charts-api.html (right):
> 
>
https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
> appengine/swarming/elements/imp/stats/load-charts-api.html:2: # Copyright 2016
The LUCI Authors. All rights reserved.
> How does the directory structure relate the apps (index.html and botlist.html)
?

This stats/ folder contains the elements that have been ported from Polymer05,
which are all a part of a "stats" page. 
https://chromium-swarm-dev.appspot.com/stats?{%22duration%22:120,%22resolutio...

So, imp/index imp/botlist and imp/stats are three different "apps".  stats
currently does not have a top level page with it yet, I was just moving it to
get all the structure the same way.

[kjlubick, 2016-07-26 13:56:00]

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/Makefile (right):

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/Makefile:26: ./node_modules/.bin/vulcanize
--inline-css=true --inline-scripts=true --strip-comments=true
--out-html=./build/index-build.html index.html
On 2016/07/26 at 12:55:09, jcgregorio wrote:
> Instead of vulcanizing index.html and botlist-index.html individually, there
should be a single file 'elements.html' that lists the top level elements, i.e.
swarming-app, swarming-index that gets vulcanized into a single file
./build/elements.html that gets imported by both index.html and botlist.html.
The advantage is that while the file will be larger, you will only need to
download it once regardless of which page you move to.
> 
> It also reduces the number of generated files to be checked into the git repo
to just one, the vulcanized elements.html.
> 
> Note that the two index files will need to import the web components polyfill
and then HTML import the elements.html file.
> 
> This will also enable 'debug' mode, which can be done in a later CL, which is
where you don't vulcanize elements.html and it just imports all of it's
dependents individually, which is slower, but makes developing and debugging
much easier.

Done.  The elements is served out of /res/elements.html, along with
/res/[polyfill].js

[stephana, 2016-07-26 17:24:02]

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
File appengine/swarming/elements/imp/stats/load-charts-api.html (right):

https://codereview.chromium.org/2177353002/diff/80001/appengine/swarming/elem...
appengine/swarming/elements/imp/stats/load-charts-api.html:2: # Copyright 2016
The LUCI Authors. All rights reserved.
On 2016/07/26 13:13:00, stephana wrote:
> How does the directory structure relate the apps (index.html and botlist.html)
?
> 
Resolved in offline conversation.

[stephana, 2016-07-26 17:29:56]

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/imp/index/swarming-index.html (right):

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/imp/index/swarming-index.html:2: Copyright 2016 The
LUCI Authors. All rights reserved.
Can you add a short explanation what the element does ?
If I understand it's the central container of everything 
on the index.html page that is not common.

[jcgregorio, 2016-07-26 17:35:02]

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/elements.html (right):

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/elements.html:11: <!-- List all the top-level pages
here-->
s/pages/elements/

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/elements.html:12: <link rel="import"
href="./imp/index/swarming-index.html" />
This OK for now, but in a near future CL this should this be
href="/res/imp/index/swarming-index.html", and there should be a .bowerrc file
that directs bower components to be checked out under
./res/imp/bower_components, again with an eye towards debugging.

[kjlubick, 2016-07-26 19:23:36]

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/elements.html (right):

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/elements.html:11: <!-- List all the top-level pages
here-->
On 2016/07/26 at 17:35:01, jcgregorio wrote:
> s/pages/elements/

Done.

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/elements.html:12: <link rel="import"
href="./imp/index/swarming-index.html" />
On 2016/07/26 at 17:35:01, jcgregorio wrote:
> This OK for now, but in a near future CL this should this be
href="/res/imp/index/swarming-index.html", and there should be a .bowerrc file
that directs bower components to be checked out under
./res/imp/bower_components, again with an eye towards debugging.

Done now, before it gets to hairy.

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/imp/index/swarming-index.html (right):

https://codereview.chromium.org/2177353002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/imp/index/swarming-index.html:2: Copyright 2016 The
LUCI Authors. All rights reserved.
On 2016/07/26 at 17:29:56, stephana wrote:
> Can you add a short explanation what the element does ?
> If I understand it's the central container of everything 
> on the index.html page that is not common.

Done.

[jcgregorio, 2016-07-26 19:27:42]

lgtm

[kjlubick, 2016-07-26 19:28:17]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-07-26 19:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:28:24]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-07-26 19:28:42]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-07-26 19:28:43]

lgtm

[KevinL, 2016-07-26 19:28:47]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:32:58]

Description was changed from

==========
Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

This also moves the elements/stats to elements/imp/stats, which was overlooked
in the last CL.

BUG=631047
==========

to

==========
Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

This also moves the elements/stats to elements/imp/stats, which was overlooked
in the last CL.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/bc79132b9686e2553be97baef8a74bba547d5354
==========

[commit-bot: I haz the power, 2016-07-26 19:33:00]

Committed patchset #8 (id:140001) as
https://github.com/luci/luci-py/commit/bc79132b9686e2553be97baef8a74bba547d5354