Add stub pages and oauth-blessed request to /newui

Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be incorporating the (mostly written) bot-list to also use it. 

BUG=631047
Committed: https://github.com/luci/luci-py/commit/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81

[kjlubick, 2016-07-22 20:47:47]

Description was changed from

==========
Add stub pages and oauth-blessed request to /newui

BUG=
==========

to

==========
Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with
iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be
incorporating the (mostly written) bot-list to also use it. 

BUG=
==========

[kjlubick, 2016-07-22 20:47:47]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[stephana, 2016-07-24 21:17:07]

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/app....
File appengine/swarming/app.yaml (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/app....
appengine/swarming/app.yaml:69: - url: /newui/
Nit: It looks like the elements folder will contain the entire frontent app
(including the index.html file). 
In the long term the application path should match the path of the file system
where the ui lives.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/Makefile (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/Makefile:22: npm install vulcanize
Instead of hitting npm install every time it would preferable to have a
package.json file and add 

npm install 

to README.  That way we can also capture other dependencies that might come up
and also version vulcanize.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/README.md (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/README.md:9: These are checked into version control
so that they may be easily redeployed w/o having to rebuild
IMO, checking the combined apps into source control is error prone. Repeated
deployment of the same app can be simplified by the deployment system, i.e.
similar to the mechanism that skia-buildbot uses with push and Debian packages.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/bower.json (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/bower.json:15: "google-signin":
"GoogleWebComponents/google-signin#^1.3.2",
Just like with the 'iron-elements' line below, something like 

 ...
 "google-web-components": "GoogleWebComponents/google-web-components#^1.1.0",
...

would import all of them.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/common/auth-signin.html (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/common/auth-signin.html:88: _onSignin: function(e) {
Empty line between methods.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/common/auth-signin.html:112: signIn: function() {
If they are public facing functions signIn and signOut should be documented in
the header under "methods".

[kjlubick, 2016-07-25 12:45:44]

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/app....
File appengine/swarming/app.yaml (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/app....
appengine/swarming/app.yaml:69: - url: /newui/
On 2016/07/24 at 21:17:06, stephana wrote:
> Nit: It looks like the elements folder will contain the entire frontend app
(including the index.html file). 

This is true.

> In the long term the application path should match the path of the file system
where the ui lives.

I'm not quite sure what you mean by this.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/Makefile (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/Makefile:22: npm install vulcanize
On 2016/07/24 at 21:17:06, stephana wrote:
> Instead of hitting npm install every time it would preferable to have a
package.json file and add 
> 
> npm install 
> 
> to README.  That way we can also capture other dependencies that might come up
and also version vulcanize.

Done.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/README.md (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/README.md:9: These are checked into version control
so that they may be easily redeployed w/o having to rebuild
On 2016/07/24 at 21:17:06, stephana wrote:
> IMO, checking the combined apps into source control is error prone. Repeated
deployment of the same app can be simplified by the deployment system, i.e.
similar to the mechanism that skia-buildbot uses with push and Debian packages.

I would also prefer what you suggested.  M-A has requested it to be this way.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/bower.json (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/bower.json:15: "google-signin":
"GoogleWebComponents/google-signin#^1.3.2",
On 2016/07/24 at 21:17:07, stephana wrote:
> Just like with the 'iron-elements' line below, something like 
> 
>  ...
>  "google-web-components": "GoogleWebComponents/google-web-components#^1.1.0",
> ...
> 
> would import all of them.

Done.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/bower.json:15: "google-signin":
"GoogleWebComponents/google-signin#^1.3.2",
On 2016/07/24 at 21:17:07, stephana wrote:
> Just like with the 'iron-elements' line below, something like 
> 
>  ...
>  "google-web-components": "GoogleWebComponents/google-web-components#^1.1.0",
> ...
> 
> would import all of them.

Done.  I kept google-signin just to make sure the version is appropriate.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/common/auth-signin.html (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/common/auth-signin.html:88: _onSignin: function(e) {
On 2016/07/24 at 21:17:07, stephana wrote:
> Empty line between methods.

Done.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/common/auth-signin.html:112: signIn: function() {
On 2016/07/24 at 21:17:07, stephana wrote:
> If they are public facing functions signIn and signOut should be documented in
the header under "methods".

Done.  I had also forgotten to document the auth-signin event.

[kjlubick, 2016-07-25 13:10:59]

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/app....
File appengine/swarming/app.yaml (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/app....
appengine/swarming/app.yaml:69: - url: /newui/
On 2016/07/25 at 12:45:43, kjlubick wrote:
> On 2016/07/24 at 21:17:06, stephana wrote:
> > Nit: It looks like the elements folder will contain the entire frontend app
(including the index.html file). 
> 
> This is true.
> 
> > In the long term the application path should match the path of the file
system where the ui lives.
> 
> I'm not quite sure what you mean by this.

I added a TODO to consider this later when it is closer to completion.

[stephana, 2016-07-25 13:26:32]

LGTM module small nits

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/README.md (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/README.md:9: These are checked into version control
so that they may be easily redeployed w/o having to rebuild
On 2016/07/25 12:45:43, kjlubick wrote:
> On 2016/07/24 at 21:17:06, stephana wrote:
> > IMO, checking the combined apps into source control is error prone. Repeated
> deployment of the same app can be simplified by the deployment system, i.e.
> similar to the mechanism that skia-buildbot uses with push and Debian
packages.
> 
> I would also prefer what you suggested.  M-A has requested it to be this way.

Acknowledged.

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
File appengine/swarming/elements/bower.json (right):

https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
appengine/swarming/elements/bower.json:15: "google-signin":
"GoogleWebComponents/google-signin#^1.3.2",
On 2016/07/25 12:45:43, kjlubick wrote:
> On 2016/07/24 at 21:17:07, stephana wrote:
> > Just like with the 'iron-elements' line below, something like 
> > 
> >  ...
> >  "google-web-components":
"GoogleWebComponents/google-web-components#^1.1.0",
> > ...
> > 
> > would import all of them.
> 
> Done.

The trailing "#^1.3.2" ensures that you get the newest version since 1.3.2 which
is already covered by the webcomponent dependency.

[kjlubick, 2016-07-25 15:18:11]

Description was changed from

==========
Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with
iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be
incorporating the (mostly written) bot-list to also use it. 

BUG=
==========

to

==========
Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with
iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be
incorporating the (mostly written) bot-list to also use it. 

BUG=631047
==========

[kjlubick, 2016-07-25 15:25:57]

On 2016/07/25 at 13:26:32, stephana wrote:
> LGTM module small nits
> 
>
https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
> File appengine/swarming/elements/README.md (right):
> 
>
https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
> appengine/swarming/elements/README.md:9: These are checked into version
control so that they may be easily redeployed w/o having to rebuild
> On 2016/07/25 12:45:43, kjlubick wrote:
> > On 2016/07/24 at 21:17:06, stephana wrote:
> > > IMO, checking the combined apps into source control is error prone.
Repeated
> > deployment of the same app can be simplified by the deployment system, i.e.
> > similar to the mechanism that skia-buildbot uses with push and Debian
packages.
> > 
> > I would also prefer what you suggested.  M-A has requested it to be this
way.
> 
> Acknowledged.
> 
>
https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
> File appengine/swarming/elements/bower.json (right):
> 
>
https://codereview.chromium.org/2174903002/diff/40001/appengine/swarming/elem...
> appengine/swarming/elements/bower.json:15: "google-signin":
"GoogleWebComponents/google-signin#^1.3.2",
> On 2016/07/25 12:45:43, kjlubick wrote:
> > On 2016/07/24 at 21:17:07, stephana wrote:
> > > Just like with the 'iron-elements' line below, something like 
> > > 
> > >  ...
> > >  "google-web-components":
"GoogleWebComponents/google-web-components#^1.1.0",
> > > ...
> > > 
> > > would import all of them.
> > 
> > Done.
> 
> The trailing "#^1.3.2" ensures that you get the newest version since 1.3.2
which is already covered by the webcomponent dependency.

Excellent.  I removed the iron-flex-layout dependency too, for the same reason.

[jcgregorio, 2016-07-25 15:46:05]

https://codereview.chromium.org/2174903002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/index.html (right):

https://codereview.chromium.org/2174903002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/index.html:1: <!--
Not sure about the file structure at this point, there should be dir structure
that separates out elements, html pages, and possibly CSS and JS files if there
are any standalone versions of those.

[kjlubick, 2016-07-25 15:52:22]

On 2016/07/25 at 15:46:05, jcgregorio wrote:
>
https://codereview.chromium.org/2174903002/diff/120001/appengine/swarming/ele...
> File appengine/swarming/elements/index.html (right):
> 
>
https://codereview.chromium.org/2174903002/diff/120001/appengine/swarming/ele...
> appengine/swarming/elements/index.html:1: <!--
> Not sure about the file structure at this point, there should be dir structure
that separates out elements, html pages, and possibly CSS and JS files if there
are any standalone versions of those.

The top level html (e.g. elements/index.html and elements/botlist.html) will be
vulcanized into elements/build/.  Other than that, there should only be Polymer,
separated into folders that are mostly app-specific (e.g. elements/index/ and
elements/botlist/).  I'm not planning to have any standalone JS or CSS (Using
https://www.polymer-project.org/1.0/docs/devguide/behaviors and polymer's style
modules instead).

[kjlubick, 2016-07-25 16:07:39]

On 2016/07/25 at 15:52:22, kjlubick wrote:
> On 2016/07/25 at 15:46:05, jcgregorio wrote:
> >
https://codereview.chromium.org/2174903002/diff/120001/appengine/swarming/ele...
> > File appengine/swarming/elements/index.html (right):
> > 
> >
https://codereview.chromium.org/2174903002/diff/120001/appengine/swarming/ele...
> > appengine/swarming/elements/index.html:1: <!--
> > Not sure about the file structure at this point, there should be dir
structure that separates out elements, html pages, and possibly CSS and JS files
if there are any standalone versions of those.
> 
> The top level html (e.g. elements/index.html and elements/botlist.html) will
be vulcanized into elements/build/.  Other than that, there should only be
Polymer, separated into folders that are mostly app-specific (e.g.
elements/index/ and elements/botlist/).  I'm not planning to have any standalone
JS or CSS (Using https://www.polymer-project.org/1.0/docs/devguide/behaviors and
polymer's style modules instead).

As per our discussion, I added an "imp" folder, which stands for imports, as in,
any Polymer elements that need to be imported.

[jcgregorio, 2016-07-25 16:09:02]

lgtm

[kjlubick, 2016-07-25 16:14:58]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-07-25 16:14:59]

The patchset sent to the CQ was uploaded after l-g-t-m from stephana@google.com
Link to the patchset: https://codereview.chromium.org/2174903002/#ps140001
(title: "Add imp folder")

[commit-bot: I haz the power, 2016-07-25 16:15:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 16:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:15:11]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-07-25 16:15:24]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-07-25 16:15:25]

lgtm

[kjlubick, 2016-07-25 16:15:39]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-07-25 16:15:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 16:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:15:50]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[M-A Ruel, 2016-07-25 16:30:20]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-07-25 16:30:21]

https://codereview.chromium.org/2174903002/diff/140001/appengine/swarming/app...
File appengine/swarming/app.yaml (right):

https://codereview.chromium.org/2174903002/diff/140001/appengine/swarming/app...
appengine/swarming/app.yaml:75: # TODO(maruel): Unsure about polymer if it is
inline-style free.
https://github.com/PolymerLabs/crisper fixes inline-js, I'm not sure if
inline-style is still relevant. Anyhow, the TODO should be assigned to kjlubick.

https://codereview.chromium.org/2174903002/diff/140001/appengine/swarming/app...
appengine/swarming/app.yaml:76: # TODO(maruel): Polymer abuses eval() and
http://crbug.com/277857 gets in
This bug is closed.

[kjlubick, 2016-07-25 17:54:51]

https://codereview.chromium.org/2174903002/diff/140001/appengine/swarming/app...
File appengine/swarming/app.yaml (right):

https://codereview.chromium.org/2174903002/diff/140001/appengine/swarming/app...
appengine/swarming/app.yaml:75: # TODO(maruel): Unsure about polymer if it is
inline-style free.
On 2016/07/25 at 16:30:21, M-A Ruel wrote:
> https://github.com/PolymerLabs/crisper fixes inline-js, I'm not sure if
inline-style is still relevant. Anyhow, the TODO should be assigned to kjlubick.

I just removed this and it seemed to work.

https://codereview.chromium.org/2174903002/diff/140001/appengine/swarming/app...
appengine/swarming/app.yaml:76: # TODO(maruel): Polymer abuses eval() and
http://crbug.com/277857 gets in
On 2016/07/25 at 16:30:21, M-A Ruel wrote:
> This bug is closed.


I just removed this and it seemed to work.

[kjlubick, 2016-07-25 17:54:54]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-07-25 17:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjlubick@chromium.org, jcgregorio@google.com, stephana@google.com
Link to the patchset: https://codereview.chromium.org/2174903002/#ps160001
(title: "Remove unneeded headers")

[commit-bot: I haz the power, 2016-07-25 17:55:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 17:55:04]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[M-A Ruel, 2016-07-25 17:59:08]

lgtm

[M-A Ruel, 2016-07-25 18:00:06]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2016-07-25 18:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 18:03:05]

Description was changed from

==========
Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with
iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be
incorporating the (mostly written) bot-list to also use it. 

BUG=631047
==========

to

==========
Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with
iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be
incorporating the (mostly written) bot-list to also use it. 

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81
==========

[commit-bot: I haz the power, 2016-07-25 18:03:07]

Committed patchset #9 (id:160001) as
https://github.com/luci/luci-py/commit/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81