Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
index 6faa08e31304b61f046b2286e020d3f1f6afb9cc..d4e4defbfc398e90619296fa12d9dd04eae53874 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
@@ -16,6 +16,7 @@
#include "modules/fetch/BodyStreamBuffer.h"
#include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
#include "platform/RuntimeEnabledFeatures.h"
+#include "public/platform/Platform.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h"
#include "wtf/Assertions.h"
#include "wtf/RefPtr.h"
@@ -86,16 +87,6 @@ bool isClientRequest(WebURLRequest::FrameType frameType, WebURLRequest::RequestC
return isNavigationRequest(frameType) || requestContext == WebURLRequest::RequestContextSharedWorker || requestContext == WebURLRequest::RequestContextWorker;
}
-class NoopLoaderClient final : public GarbageCollectedFinalized<NoopLoaderClient>, public FetchDataLoader::Client {
- WTF_MAKE_NONCOPYABLE(NoopLoaderClient);
- USING_GARBAGE_COLLECTED_MIXIN(NoopLoaderClient);
-public:
- NoopLoaderClient() = default;
- void didFetchDataLoadedStream() override {}
- void didFetchDataLoadFailed() override {}
- DEFINE_INLINE_TRACE() { FetchDataLoader::Client::trace(visitor); }
-};
-
} // namespace
class RespondWithObserver::ThenFunction final : public ScriptFunction {
@@ -264,7 +255,7 @@ void RespondWithObserver::responseWasFulfilled(const ScriptValue& value)
} else {
Stream* outStream = Stream::create(getExecutionContext(), "");
webResponse.setStreamURL(outStream->url());
- buffer->startLoading(FetchDataLoader::createLoaderAsStream(outStream), new NoopLoaderClient);
+ buffer->startLoading(FetchDataLoader::createLoaderAsStream(outStream), nullptr);
}
}
ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID, webResponse);

Powered by Google App Engine
This is Rietveld 408576698