third_party/WebKit/Source/modules/fetch/ResponseTest.cpp - Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2177243002: Use per-frame TaskRunner instead of thread's default in DataConsumerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_data_consumer_handle_impl.cc ('K') | « third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | third_party/WebKit/public/platform/WebDataConsumerHandle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

index d9aa422341c96e2ec6dfe3160d3e54571e97ca85..542eba3b42ee7a15d3fca9b0138a9efca1ae66ab 100644

--- a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

@@ -175,6 +175,10 @@ void checkResponseStream(ScriptState* scriptState, Response* response, bool chec

EXPECT_CALL(*client1, didFetchDataLoadedString(String("Hello, world")));

EXPECT_CALL(*client2, didFetchDataLoadedString(String("Hello, world")));

+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();

+ EXPECT_CALL(*client1, getTaskRunner()).WillRepeatedly(::testing::Return(taskRunner));

+ EXPECT_CALL(*client2, getTaskRunner()).WillRepeatedly(::testing::Return(taskRunner));

response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAsString(), client1);

clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAsString(), client2);

blink::testing::runPendingTasks();

@@ -253,6 +257,10 @@ TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneError)

EXPECT_CALL(*client1, didFetchDataLoadFailed());