chrome/browser/ssl/ssl_browser_tests.cc - Issue 2177233002: binding: Calls didAccessInitialDocument() for a returned Window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2177233002: binding: Calls didAccessInitialDocument() for a returned Window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated SSLUITest's test expectation. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 68405e7ac23441f6e9ff6804f8be9396d2d9aecd..328a32a7a68d4754b8f34a5d12c06191dbafdd41 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -1891,9 +1891,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestCloseTabWithUnsafePopup) {

// Since the popup is showing an interstitial, it shouldn't have a last

// committed entry.

EXPECT_FALSE(popup->GetController().GetLastCommittedEntry());

- ASSERT_TRUE(popup->GetController().GetVisibleEntry());

- EXPECT_EQ(https_server_expired_.GetURL("/ssl/bad_iframe.html"),

- popup->GetController().GetVisibleEntry()->GetURL());

+ EXPECT_EQ(nullptr, popup->GetController().GetVisibleEntry());

content::WaitForInterstitialAttach(popup);

EXPECT_TRUE(popup->ShowingInterstitialPage());

« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »