Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/browser/apps/app_browsertest.cc

Issue 2177233002: binding: Calls didAccessInitialDocument() for a returned Window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated SSLUITest's test expectation. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "apps/launcher.h" 9 #include "apps/launcher.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 // fixed. 446 // fixed.
447 // const size_t kExpectedNumberOfTabs = 2u; 447 // const size_t kExpectedNumberOfTabs = 2u;
448 const size_t kExpectedNumberOfTabs = 6u; 448 const size_t kExpectedNumberOfTabs = 6u;
449 TabsAddedNotificationObserver observer(kExpectedNumberOfTabs); 449 TabsAddedNotificationObserver observer(kExpectedNumberOfTabs);
450 ASSERT_TRUE(RunPlatformAppTest("platform_apps/background_page_navigation")) << 450 ASSERT_TRUE(RunPlatformAppTest("platform_apps/background_page_navigation")) <<
451 message_; 451 message_;
452 observer.Wait(); 452 observer.Wait();
453 ASSERT_EQ(kExpectedNumberOfTabs, observer.tabs().size()); 453 ASSERT_EQ(kExpectedNumberOfTabs, observer.tabs().size());
454 EXPECT_EQ(GURL(kChromiumURL), 454 EXPECT_EQ(GURL(kChromiumURL),
455 observer.tabs()[kExpectedNumberOfTabs - 1]->GetURL()); 455 observer.tabs()[kExpectedNumberOfTabs - 1]->GetURL());
456 EXPECT_EQ(GURL(kChromiumURL), 456 EXPECT_EQ(GURL(""),
457 observer.tabs()[kExpectedNumberOfTabs - 2]->GetURL()); 457 observer.tabs()[kExpectedNumberOfTabs - 2]->GetURL());
458 } 458 }
459 459
460 // Failing on some Win and Linux buildbots. See crbug.com/354425. 460 // Failing on some Win and Linux buildbots. See crbug.com/354425.
461 #if defined(OS_WIN) || defined(OS_LINUX) 461 #if defined(OS_WIN) || defined(OS_LINUX)
462 #define MAYBE_Iframes DISABLED_Iframes 462 #define MAYBE_Iframes DISABLED_Iframes
463 #else 463 #else
464 #define MAYBE_Iframes Iframes 464 #define MAYBE_Iframes Iframes
465 #endif 465 #endif
466 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_Iframes) { 466 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_Iframes) {
(...skipping 915 matching lines...) Expand 10 before | Expand all | Expand 10 after
1382 // https://crbug.com/620194. 1382 // https://crbug.com/620194.
1383 #define MAYBE_AppWindowIframe DISABLED_AppWindowIframe 1383 #define MAYBE_AppWindowIframe DISABLED_AppWindowIframe
1384 // Sends chrome.test.sendMessage from chrome.app.window.create's callback. 1384 // Sends chrome.test.sendMessage from chrome.app.window.create's callback.
1385 // The app window also adds an <iframe> to the page during window.onload. 1385 // The app window also adds an <iframe> to the page during window.onload.
1386 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWindowIframe) { 1386 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWindowIframe) {
1387 LoadAndLaunchPlatformApp("app_window_send_message", 1387 LoadAndLaunchPlatformApp("app_window_send_message",
1388 "APP_WINDOW_CREATE_CALLBACK"); 1388 "APP_WINDOW_CREATE_CALLBACK");
1389 } 1389 }
1390 1390
1391 } // namespace extensions 1391 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698