Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2177213002: Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation (Closed)

Created:
4 years, 5 months ago by vasilii
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation The flakiness caused by not waiting for the password store to reply with the results. BUG=629459 Committed: https://crrev.com/2ae14e9e622edd6d991dd0899c892ef8dac2cd64 Cr-Commit-Position: refs/heads/master@{#407482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/password_manager/credential_manager_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
vasilii
Hi Vaclav, please review.
4 years, 5 months ago (2016-07-25 12:14:21 UTC) #4
vabr (Chromium)
LGTM, thanks for healing our tests! Vaclav
4 years, 5 months ago (2016-07-25 13:44:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177213002/1
4 years, 5 months ago (2016-07-25 15:33:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 15:36:35 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 15:38:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ae14e9e622edd6d991dd0899c892ef8dac2cd64
Cr-Commit-Position: refs/heads/master@{#407482}

Powered by Google App Engine
This is Rietveld 408576698