chrome/browser/password_manager/credential_manager_browsertest.cc - Issue 2177213002: Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/credential_manager_browsertest.cc

Issue 2177213002: Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/credential_manager_browsertest.cc

diff --git a/chrome/browser/password_manager/credential_manager_browsertest.cc b/chrome/browser/password_manager/credential_manager_browsertest.cc

index 388d76429db472803a46f02b4f8683636612eed3..9660f51e73de4c8c86c3f9b4aea43cb9945e6928 100644

--- a/chrome/browser/password_manager/credential_manager_browsertest.cc

+++ b/chrome/browser/password_manager/credential_manager_browsertest.cc

@@ -92,6 +92,7 @@ IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,

RenderViewHost(),

"navigator.credentials.get({password: true})"

".then(cred => window.location = '/password/done.html')"));

+ WaitForPasswordStore();

ASSERT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,

PasswordsModelDelegateFromWebContents(WebContents())->GetState());

PasswordsModelDelegateFromWebContents(WebContents())->ChooseCredential(

« no previous file with comments | « no previous file | no next file » | no next file with comments »