Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2177133002: [turbofan] Remove overly restrictive DCHECK. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove overly restrictive DCHECK. The dead code elimination in SimplifiedLowering can eliminate pure nodes if they don't have value uses. But some of those can indeed have control inputs, i.e. Phi nodes do of course have a control input. R=jarin@chromium.org BUG=chromium:630923 Committed: https://crrev.com/e3e347b85ccdb6113e0a87272005fd8d7200bf0f Cr-Commit-Position: refs/heads/master@{#37995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-630923.js View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-25 04:58:06 UTC) #1
Jarin
lgtm. Thanks!
4 years, 5 months ago (2016-07-25 04:59:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177133002/1
4 years, 5 months ago (2016-07-25 04:59:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 05:21:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 05:22:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3e347b85ccdb6113e0a87272005fd8d7200bf0f
Cr-Commit-Position: refs/heads/master@{#37995}

Powered by Google App Engine
This is Rietveld 408576698