Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 2177133002: [turbofan] Remove overly restrictive DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-630923.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/address-map.h" 9 #include "src/address-map.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2427 matching lines...) Expand 10 before | Expand all | Expand 10 after
2438 void Kill(Node* node) { 2438 void Kill(Node* node) {
2439 TRACE("killing #%d:%s\n", node->id(), node->op()->mnemonic()); 2439 TRACE("killing #%d:%s\n", node->id(), node->op()->mnemonic());
2440 2440
2441 if (node->op()->EffectInputCount() == 1) { 2441 if (node->op()->EffectInputCount() == 1) {
2442 DCHECK_LT(0, node->op()->ControlInputCount()); 2442 DCHECK_LT(0, node->op()->ControlInputCount());
2443 // Disconnect the node from effect and control chains. 2443 // Disconnect the node from effect and control chains.
2444 Node* control = NodeProperties::GetControlInput(node); 2444 Node* control = NodeProperties::GetControlInput(node);
2445 Node* effect = NodeProperties::GetEffectInput(node); 2445 Node* effect = NodeProperties::GetEffectInput(node);
2446 ReplaceEffectControlUses(node, effect, control); 2446 ReplaceEffectControlUses(node, effect, control);
2447 } else { 2447 } else {
2448 DCHECK_EQ(0, node->op()->ControlInputCount());
2449 DCHECK_EQ(0, node->op()->EffectInputCount()); 2448 DCHECK_EQ(0, node->op()->EffectInputCount());
2450 DCHECK_EQ(0, node->op()->ControlOutputCount()); 2449 DCHECK_EQ(0, node->op()->ControlOutputCount());
2451 DCHECK_EQ(0, node->op()->EffectOutputCount()); 2450 DCHECK_EQ(0, node->op()->EffectOutputCount());
2452 } 2451 }
2453 2452
2454 node->ReplaceUses(jsgraph_->Dead()); 2453 node->ReplaceUses(jsgraph_->Dead());
2455 2454
2456 node->NullAllInputs(); // The {node} is now dead. 2455 node->NullAllInputs(); // The {node} is now dead.
2457 } 2456 }
2458 2457
(...skipping 1053 matching lines...) Expand 10 before | Expand all | Expand 10 after
3512 isolate(), graph()->zone(), callable.descriptor(), 0, flags, 3511 isolate(), graph()->zone(), callable.descriptor(), 0, flags,
3513 Operator::kNoProperties); 3512 Operator::kNoProperties);
3514 to_number_operator_.set(common()->Call(desc)); 3513 to_number_operator_.set(common()->Call(desc));
3515 } 3514 }
3516 return to_number_operator_.get(); 3515 return to_number_operator_.get();
3517 } 3516 }
3518 3517
3519 } // namespace compiler 3518 } // namespace compiler
3520 } // namespace internal 3519 } // namespace internal
3521 } // namespace v8 3520 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-630923.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698