Refactor StyleInvalidator to encapsulate all style invalidation state.

Refactor StyleInvalidator to encapsulate all style invalidation state.

This is a nice cleanup, and sets us up for separating StyleInvalidator from 
RuleFeatureSet, which will allow us to more easily  TargetedStyleRecalc for style 
sheet loads.

BUG=318468
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170485

[esprehn, 2014-03-31 18:20:39]

You want an API on StyleResolver that you talk to. Callers of invalidate() and
such shouldn't need to reach way down the object graph.

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
File Source/core/css/invalidation/StyleInvalidator.cpp (right):

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.cpp:34:
StyleInvalidator::InvalidationList&
StyleInvalidator::ensurePendingInvalidationList(Element* element)
by reference

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.cpp:53: m_recursionData.clear();
How is it possible to have recursion data at this point?

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
File Source/core/css/invalidation/StyleInvalidator.h (right):

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.h:20: void
scheduleInvalidation(PassRefPtr<DescendantInvalidationSet>, Element*);
by reference

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.h:23: void
clearStyleInvalidation(Node*);
by reference

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.h:25: void clear();
This needs a better name.

https://codereview.chromium.org/217713002/diff/80001/Source/core/dom/Document...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/217713002/diff/80001/Source/core/dom/Document...
Source/core/dom/Document.cpp:1593:
styleResolver()->ruleFeatureSet().styleInvalidator().invalidate(*this);
This is really silly to reach so far down, you should encapsulate this with an
API on StyleResolver.

See also http://en.wikipedia.org/wiki/Law_of_Demeter

[chrishtr, 2014-03-31 19:22:59]

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
File Source/core/css/invalidation/StyleInvalidator.cpp (right):

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.cpp:34:
StyleInvalidator::InvalidationList&
StyleInvalidator::ensurePendingInvalidationList(Element* element)
On 2014/03/31 18:20:39, esprehn wrote:
> by reference

Done.

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.cpp:53: m_recursionData.clear();
On 2014/03/31 18:20:39, esprehn wrote:
> How is it possible to have recursion data at this point?

It should not be possible. Removed.

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
File Source/core/css/invalidation/StyleInvalidator.h (right):

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.h:20: void
scheduleInvalidation(PassRefPtr<DescendantInvalidationSet>, Element*);
On 2014/03/31 18:20:39, esprehn wrote:
> by reference

Done.

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.h:23: void
clearStyleInvalidation(Node*);
On 2014/03/31 18:20:39, esprehn wrote:
> by reference

Done.

https://codereview.chromium.org/217713002/diff/80001/Source/core/css/invalida...
Source/core/css/invalidation/StyleInvalidator.h:25: void clear();
On 2014/03/31 18:20:39, esprehn wrote:
> This needs a better name.

Done.

https://codereview.chromium.org/217713002/diff/80001/Source/core/dom/Document...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/217713002/diff/80001/Source/core/dom/Document...
Source/core/dom/Document.cpp:1593:
styleResolver()->ruleFeatureSet().styleInvalidator().invalidate(*this);
On 2014/03/31 18:20:39, esprehn wrote:
> This is really silly to reach so far down, you should encapsulate this with an
> API on StyleResolver.
> 
> See also http://en.wikipedia.org/wiki/Law_of_Demeter

Don't disagree. This CL is one step towards that.

[esprehn, 2014-03-31 19:45:32]

lgtm

https://codereview.chromium.org/217713002/diff/140001/Source/core/css/invalid...
File Source/core/css/invalidation/StyleInvalidator.h (right):

https://codereview.chromium.org/217713002/diff/140001/Source/core/css/invalid...
Source/core/css/invalidation/StyleInvalidator.h:18: explicit StyleInvalidator();
You don't need explicit since this doesn't take any arguments.

[chrishtr, 2014-03-31 20:07:37]

https://codereview.chromium.org/217713002/diff/140001/Source/core/css/invalid...
File Source/core/css/invalidation/StyleInvalidator.h (right):

https://codereview.chromium.org/217713002/diff/140001/Source/core/css/invalid...
Source/core/css/invalidation/StyleInvalidator.h:18: explicit StyleInvalidator();
On 2014/03/31 19:45:33, esprehn wrote:
> You don't need explicit since this doesn't take any arguments.

Done.

[chrishtr, 2014-03-31 20:08:01]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-03-31 20:08:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrishtr@chromium.org/217713002/160001

[commit-bot: I haz the power, 2014-03-31 20:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 20:25:17]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[chrishtr, 2014-03-31 21:16:58]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-03-31 21:17:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrishtr@chromium.org/217713002/160001

[commit-bot: I haz the power, 2014-03-31 23:51:28]

Change committed as 170485