Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 217713002: Refactor StyleInvalidator to encapsulate all style invalidation state. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove explicit. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/invalidation/StyleInvalidator.h ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/invalidation/StyleInvalidator.cpp
diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp
index fe400494f515777168ffb5def3c8e6dbd9129aff..cd53db244ef75f468a674bab7496a822d8228e87 100644
--- a/Source/core/css/invalidation/StyleInvalidator.cpp
+++ b/Source/core/css/invalidation/StyleInvalidator.cpp
@@ -16,18 +16,43 @@
namespace WebCore {
-void StyleInvalidator::invalidate()
+void StyleInvalidator::invalidate(Document& document)
{
- if (Element* documentElement = m_document.documentElement())
+ if (Element* documentElement = document.documentElement())
invalidate(*documentElement);
- m_document.clearChildNeedsStyleInvalidation();
- m_document.clearNeedsStyleInvalidation();
+ document.clearChildNeedsStyleInvalidation();
+ document.clearNeedsStyleInvalidation();
+ clearPendingInvalidations();
+}
+
+void StyleInvalidator::scheduleInvalidation(PassRefPtr<DescendantInvalidationSet> invalidationSet, Element& element)
+{
+ ensurePendingInvalidationList(element).append(invalidationSet);
+ element.setNeedsStyleInvalidation();
+}
+
+StyleInvalidator::InvalidationList& StyleInvalidator::ensurePendingInvalidationList(Element& element)
+{
+ PendingInvalidationMap::AddResult addResult = m_pendingInvalidationMap.add(&element, nullptr);
+ if (addResult.isNewEntry)
+ addResult.storedValue->value = adoptPtr(new InvalidationList);
+ return *addResult.storedValue->value;
+}
+
+void StyleInvalidator::clearInvalidation(Node& node)
+{
+ node.clearChildNeedsStyleInvalidation();
+ node.clearNeedsStyleInvalidation();
+ if (node.isElementNode())
+ m_pendingInvalidationMap.remove(toElement(&node));
+}
+
+void StyleInvalidator::clearPendingInvalidations()
+{
m_pendingInvalidationMap.clear();
}
-StyleInvalidator::StyleInvalidator(Document& document)
- : m_document(document)
- , m_pendingInvalidationMap(document.styleResolver()->ruleFeatureSet().pendingInvalidationMap())
+StyleInvalidator::StyleInvalidator()
{ }
void StyleInvalidator::RecursionData::pushInvalidationSet(const DescendantInvalidationSet& invalidationSet)
@@ -60,10 +85,10 @@ bool StyleInvalidator::checkInvalidationSetsAgainstElement(Element& element)
{
bool thisElementNeedsStyleRecalc = false;
if (element.needsStyleInvalidation()) {
- if (RuleFeatureSet::InvalidationList* invalidationList = m_pendingInvalidationMap.get(&element)) {
+ if (InvalidationList* invalidationList = m_pendingInvalidationMap.get(&element)) {
// FIXME: it's really only necessary to clone the render style for this element, not full style recalc.
thisElementNeedsStyleRecalc = true;
- for (RuleFeatureSet::InvalidationList::const_iterator it = invalidationList->begin(); it != invalidationList->end(); ++it) {
+ for (InvalidationList::const_iterator it = invalidationList->begin(); it != invalidationList->end(); ++it) {
m_recursionData.pushInvalidationSet(**it);
if ((*it)->wholeSubtreeInvalid()) {
element.setNeedsStyleRecalc(SubtreeStyleChange);
« no previous file with comments | « Source/core/css/invalidation/StyleInvalidator.h ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698