Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2177113002: Mac File Dialogs: Add Apple radar id in comment about crash. (Closed)

Created:
4 years, 5 months ago by karandeepb
Modified:
4 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@select_file_dialog_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac File Dialogs: Add Apple radar id in comment about crash. crrev.com/2164223003 added a nil check in select_file_dialog_mac.mm to prevent crashes occuring due to CreateUTIFromExtension returning nil. This CL updates the comment added in crrev.com/2164223003 with the relevant Apple radar id. BUG=630101 Committed: https://crrev.com/32f0eb6bd979082f08c7072cdad3d7efc409ffd3 Cr-Commit-Position: refs/heads/master@{#407397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
karandeepb
PTAL avi@. You recommended doing this in https://codereview.chromium.org/2164223003/.
4 years, 5 months ago (2016-07-25 01:14:12 UTC) #3
Avi (use Gerrit)
lgtm Thank you.
4 years, 5 months ago (2016-07-25 01:14:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177113002/1
4 years, 5 months ago (2016-07-25 01:17:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 01:54:34 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 01:56:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32f0eb6bd979082f08c7072cdad3d7efc409ffd3
Cr-Commit-Position: refs/heads/master@{#407397}

Powered by Google App Engine
This is Rietveld 408576698