ui/shell_dialogs/select_file_dialog_mac.mm - Issue 2177113002: Mac File Dialogs: Add Apple radar id in comment about crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/shell_dialogs/select_file_dialog_mac.mm

Issue 2177113002: Mac File Dialogs: Add Apple radar id in comment about crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@select_file_dialog_crash

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/shell_dialogs/select_file_dialog_mac.mm

diff --git a/ui/shell_dialogs/select_file_dialog_mac.mm b/ui/shell_dialogs/select_file_dialog_mac.mm

index bf5a862562609991148364ac8a6bde4d753916d9..d944e479b15701106374328397cd69cae68bd903 100644

--- a/ui/shell_dialogs/select_file_dialog_mac.mm

+++ b/ui/shell_dialogs/select_file_dialog_mac.mm

@@ -311,7 +311,8 @@ - (void)popupAction:(id)sender;

default_extension_index = i;

// Crash reports suggest that CreateUTIFromExtension may return nil. Hence

- // we nil check before adding to |file_type_set|. See crbug.com/630101.

+ // we nil check before adding to |file_type_set|. See crbug.com/630101 and

+ // rdar://27490414.

base::ScopedCFTypeRef<CFStringRef> uti(CreateUTIFromExtension(ext));

if (uti)

[file_type_set addObject:base::mac::CFToNSCast(uti.get())];

« no previous file with comments | « no previous file | no next file » | no next file with comments »