Subzero: Local variable splitting.

src/IceInst.h

Index: src/IceInst.h
diff --git a/src/IceInst.h b/src/IceInst.h
index b8e1b6184ef311edae17c58f52782e95b5277175..8833cc7937abcba42083f5435b74d4224d42833a 100644
--- a/src/IceInst.h
+++ b/src/IceInst.h
@@ -111,8 +111,6 @@ public:
   void replaceSource(SizeT Index, Operand *Replacement) {
     assert(Index < getSrcSize());
     assert(!isDeleted());
-    assert(LiveRangesEnded == 0);
-    // Invalidates liveness info because the use Srcs[Index] is removed.
     Srcs[Index] = Replacement;
   }
 
@@ -151,6 +149,15 @@ public:
   /// report_fatal_error().
   virtual bool isMemoryWrite() const;
 
+  /// Returns true if the (target-specific) instruction represents an
+  /// intra-block label, i.e. branch target.  This is meant primarily for
+  /// Cfg::splitLocalVars().
+  virtual bool isLabel() const { return false; }
+  /// If the (target-specific) instruction represents an intra-block branch to
+  /// some Label instruction, return that Label branch target instruction;
+  /// otherwise return nullptr.
+  virtual const Inst *isIntraBlockBranch() const { return nullptr; }

[Eric Holk, 2016/07/25 19:59:22]

The "is" prefix makes me think this should be a boolean function. What about
calling it "getIntraBlockBranch" or "maybeGetIntraBlockBranch" for a rather
verbose name?

[Jim Stichnoth, 2016/07/26 05:59:09]

Done.

+
   void livenessLightweight(Cfg *Func, LivenessBV &Live);
   /// Calculates liveness for this instruction. Returns true if this instruction
   /// is (tentatively) still live and should be retained, and false if this