Correct recipe for w3c test autoroller bot.

Correct recipe for w3c test autoroller bot.

BUG=630780
Committed: https://chromium.googlesource.com/infra/infra/+/288d5827b25281a7bfa830d2d401b94530ff969e

[raikiri, 2016-07-23 02:29:37]

raikiri@google.com changed reviewers:
+ dba@chromium.org, dcampb@google.com, pschmidt@chromium.org,
qyearsley@chromium.org

[qyearsley, 2016-07-23 16:07:29]

lgtm

[raikiri, 2016-07-24 23:56:09]

dba@ 

Could you please check this?

[qyearsley, 2016-07-25 22:21:24]

Ping (Peter or Bryce)

[qyearsley, 2016-07-25 22:32:55]

On 2016/07/25 at 22:21:24, qyearsley wrote:
> Ping (Peter or Bryce)

Also, rebaseline-o-matic does this by creating a new branch by invoking git in
the script itself instead of having a separate step in the recipe
(https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...).
This may be nice to do, especially if it's not necessarily the case that there's
already a branch called "master".

[dba (chromium), 2016-07-25 22:39:18]

On 2016/07/25 22:32:55, qyearsley wrote:
> On 2016/07/25 at 22:21:24, qyearsley wrote:
> > Ping (Peter or Bryce)
> 
> Also, rebaseline-o-matic does this by creating a new branch by invoking git in
> the script itself instead of having a separate step in the recipe
>
(https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...).
> This may be nice to do, especially if it's not necessarily the case that
there's
> already a branch called "master".

Neither Peter or myself should be reviewing these changes.. someone from infra
that's not labs should be.

[raikiri, 2016-07-25 23:13:38]

raikiri@google.com changed reviewers:
- dba@chromium.org, pschmidt@chromium.org

[raikiri, 2016-07-25 23:13:38]

checkout -B will create the branch if it hasn't been made or reset it if it has

[qyearsley, 2016-07-25 23:14:20]

On 2016/07/25 at 22:39:18, dba wrote:
> On 2016/07/25 22:32:55, qyearsley wrote:
> > On 2016/07/25 at 22:21:24, qyearsley wrote:
> > > Ping (Peter or Bryce)
> > 
> > Also, rebaseline-o-matic does this by creating a new branch by invoking git
in
> > the script itself instead of having a separate step in the recipe
> >
(https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...).
> > This may be nice to do, especially if it's not necessarily the case that
there's
> > already a branch called "master".
> 
> Neither Peter or myself should be reviewing these changes.. someone from infra
that's not labs should be.

Makes sense -- will add Aaron and Dirk. Thanks :-)

[qyearsley, 2016-07-25 23:14:51]

Description was changed from

==========
Correct recipe for w3c test autoroller bot

BUG=630780
==========

to

==========
Correct recipe for w3c test autoroller bot.

BUG=630780
==========

[qyearsley, 2016-07-25 23:14:51]

qyearsley@chromium.org changed reviewers:
+ agable@chromium.org, dpranke@chromium.org

[dcampb, 2016-07-26 19:48:38]

dcampb@google.com changed reviewers:
- dcampb@google.com

[qyearsley, 2016-07-27 00:05:23]

https://codereview.chromium.org/2176973002/diff/60001/recipes/recipes/w3c_tes...
File recipes/recipes/w3c_test_autoroller.py (right):

https://codereview.chromium.org/2176973002/diff/60001/recipes/recipes/w3c_tes...
recipes/recipes/w3c_test_autoroller.py:27: api.git('checkout', '-B'
'update_w3c_tests')
Just realized that this is accidentally missing a comma after '-B'. When two
strings are placed next to each other (as in '-B' 'update_w3c_tests'), this
isn't a syntax error - this is the same as '-B' + 'update_w3c_tests' -- see the
result in w3c_test_autoroller.expected/w3c-test-autoroller.json.

[qyearsley, 2016-07-27 20:55:51]

LGTM; ping Dirk (or Aaron) -- this CL is now waiting on infra owners. After this
is committed we can find out if there's anything else to fix with the
w3c-test-autoroller.

[agable, 2016-07-27 20:59:03]

lgtm

[Dirk Pranke, 2016-07-27 21:17:49]

lgtm

[qyearsley, 2016-07-27 21:18:14]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-07-27 21:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 21:33:55]

Description was changed from

==========
Correct recipe for w3c test autoroller bot.

BUG=630780
==========

to

==========
Correct recipe for w3c test autoroller bot.

BUG=630780

Committed:
https://chromium.googlesource.com/infra/infra/+/288d5827b25281a7bfa830d2d401b...
==========

[commit-bot: I haz the power, 2016-07-27 21:33:56]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/288d5827b25281a7bfa830d2d401b...