Issue 2172183002: Revert "Remove non-immediate core page load metrics"

Issue 2172183002: Revert "Remove non-immediate core page load metrics" (Closed)

Created:
4 years, 5 months ago by msramek

Modified:
4 years, 5 months ago

Reviewers:
Bryan McQuade, shivanisha, Ilya Sherman

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert "Remove non-immediate core page load metrics" This reverts commit ea728cb128c672e9cb9c99c16c00206575584d0a. Reason for revert: Broken Linux ChromiumOS Tests. TBR=bmcquade@chromium.org,shivanisha@chromium.org,isherman@chromium.org BUG=630549 Committed: https://crrev.com/6ea2c7581324e29bf1106af332e3124a17562dbd Cr-Commit-Position: refs/heads/master@{#407113}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+313 lines, -103 lines)			Patch
M	chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc	View	15 chunks	+272 lines, -82 lines	0 comments	Download
M	chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc	View	7 chunks	+38 lines, -10 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+0 lines, -11 lines	0 comments	Download

Total messages: 6 (2 generated)

msramek

Reverting https://codereview.chromium.org/2156093002. Author and reviewers are on TBR. NOT skipping CQ checks, since the CL ...

4 years, 5 months ago (2016-07-22 08:41:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172183002/1

4 years, 5 months ago (2016-07-22 08:42:03 UTC) #3

commit-bot: I haz the power

4 years, 5 months ago (2016-07-22 09:46:30 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ea2c7581324e29bf1106af332e3124a17562dbd
Cr-Commit-Position: refs/heads/master@{#407113}