Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2176773002:
Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X (Closed)
DescriptionDisabling smoothness.tough_pinch_zoom_cases for android Nexus 5X
BUG=630701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/0dd36fd482f3a39bf2d546ceadb5e7378cc137ba
Cr-Commit-Position: refs/heads/master@{#407342}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Correcting syntax #
Total comments: 2
Patch Set 3 : Reformatting #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 ========== to ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
eyaich@google.com changed reviewers: + nednguyen@google.com
https://codereview.chromium.org/2176773002/diff/1/tools/perf/benchmarks/smoot... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/2176773002/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:287: @benchmark.Disabled('Nexus 5X') This would be nice but we don't support this syntax :P The way to disable Nexus 5x is follow the example in https://cs.chromium.org/chromium/src/tools/perf/benchmarks/battor.py?rcl=0&l=81
https://codereview.chromium.org/2176773002/diff/1/tools/perf/benchmarks/smoot... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/2176773002/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:287: @benchmark.Disabled('Nexus 5X') On 2016/07/22 19:02:14, nednguyen wrote: > This would be nice but we don't support this syntax :P > > The way to disable Nexus 5x is follow the example in > https://cs.chromium.org/chromium/src/tools/perf/benchmarks/battor.py?rcl=0&l=81 Ah yes, well worth a try! Correct syntax done.
lgtm https://codereview.chromium.org/2176773002/diff/20001/tools/perf/benchmarks/s... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/2176773002/diff/20001/tools/perf/benchmarks/s... tools/perf/benchmarks/smoothness.py:300: return (cls.IsSvelte(possible_browser) nits: can you reformat this so that it looks like: return ( # http://crbug.com/564008 cls.IsSvelte(possible_browser) or # http://crbug.com/630701 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
https://codereview.chromium.org/2176773002/diff/20001/tools/perf/benchmarks/s... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/2176773002/diff/20001/tools/perf/benchmarks/s... tools/perf/benchmarks/smoothness.py:300: return (cls.IsSvelte(possible_browser) On 2016/07/22 19:15:31, nednguyen wrote: > nits: can you reformat this so that it looks like: > return ( > # http://crbug.com/564008 > cls.IsSvelte(possible_browser) or > # http://crbug.com/630701 > possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X') Done.
The CQ bit was checked by eyaich@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2176773002/#ps40001 (title: "Reformatting")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
Description was changed from ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by sullivan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X BUG=630701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/0dd36fd482f3a39bf2d546ceadb5e7378cc137ba Cr-Commit-Position: refs/heads/master@{#407342} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0dd36fd482f3a39bf2d546ceadb5e7378cc137ba Cr-Commit-Position: refs/heads/master@{#407342} |
