Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: tools/perf/benchmarks/smoothness.py

Issue 2176773002: Disabling smoothness.tough_pinch_zoom_cases for android Nexus 5X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correcting syntax Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import multiprocessing 4 import multiprocessing
5 5
6 from core import perf_benchmark 6 from core import perf_benchmark
7 7
8 from benchmarks import silk_flags 8 from benchmarks import silk_flags
9 from measurements import smoothness 9 from measurements import smoothness
10 import page_sets 10 import page_sets
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 cases. 289 cases.
290 """ 290 """
291 page_set = page_sets.AndroidToughPinchZoomCasesPageSet 291 page_set = page_sets.AndroidToughPinchZoomCasesPageSet
292 292
293 @classmethod 293 @classmethod
294 def Name(cls): 294 def Name(cls):
295 return 'smoothness.tough_pinch_zoom_cases' 295 return 'smoothness.tough_pinch_zoom_cases'
296 296
297 @classmethod 297 @classmethod
298 def ShouldDisable(cls, possible_browser): 298 def ShouldDisable(cls, possible_browser):
299 return cls.IsSvelte(possible_browser) # http://crbug.com/564008 299 # http://crbug.com/564008, # http://crbug.com/630701
300 return (cls.IsSvelte(possible_browser)
nednguyen 2016/07/22 19:15:31 nits: can you reformat this so that it looks like:
eyaich 2016/07/22 19:19:34 Done.
301 or possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
300 302
301 303
302 @benchmark.Enabled('mac') 304 @benchmark.Enabled('mac')
303 class SmoothnessDesktopToughPinchZoomCases(_Smoothness): 305 class SmoothnessDesktopToughPinchZoomCases(_Smoothness):
304 """Measures rendering statistics for pinch-zooming in the tough pinch zoom 306 """Measures rendering statistics for pinch-zooming in the tough pinch zoom
305 cases. Uses lower zoom levels customized for desktop limits. 307 cases. Uses lower zoom levels customized for desktop limits.
306 """ 308 """
307 page_set = page_sets.DesktopToughPinchZoomCasesPageSet 309 page_set = page_sets.DesktopToughPinchZoomCasesPageSet
308 310
309 @classmethod 311 @classmethod
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 """Measures rendering statistics while scrolling advertisements.""" 479 """Measures rendering statistics while scrolling advertisements."""
478 page_set = page_sets.SyntheticToughWebglAdCasesPageSet 480 page_set = page_sets.SyntheticToughWebglAdCasesPageSet
479 481
480 @classmethod 482 @classmethod
481 def Name(cls): 483 def Name(cls):
482 return 'smoothness.tough_webgl_ad_cases' 484 return 'smoothness.tough_webgl_ad_cases'
483 485
484 @classmethod 486 @classmethod
485 def ShouldDisable(cls, possible_browser): 487 def ShouldDisable(cls, possible_browser):
486 return cls.IsSvelte(possible_browser) # http://crbug.com/574485 488 return cls.IsSvelte(possible_browser) # http://crbug.com/574485
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698