Geolocation: move from content/browser to device/

Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Committed: https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b
Cr-Commit-Position: refs/heads/master@{#408160}

[mcasas, 2016-07-22 18:31:32]

Description was changed from

==========
[wip] Geolocation: move from content/browser to device/

BUG=612334
==========

to

==========
[wip] Geolocation: move from content/browser to device/

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-22 19:00:11]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-07-22 23:50:38]

Patchset #2 (id:40001) has been deleted

[mcasas, 2016-07-22 23:50:44]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-07-23 00:16:58]

Description was changed from

==========
[wip] Geolocation: move from content/browser to device/

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) as that forces
 adding geolocation_export.h (like other //device/ folders).

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-23 00:23:13]

Patchset #1 (id:60001) has been deleted

[mcasas, 2016-07-23 00:30:20]

Patchset #1 (id:80001) has been deleted

[mcasas, 2016-07-23 00:31:45]

Description was changed from

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) as that forces
 adding geolocation_export.h (like other //device/ folders).

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) as that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-23 01:14:45]

Patchset #1 (id:100001) has been deleted

[mcasas, 2016-07-23 02:32:41]

Patchset #2 (id:130001) has been deleted

[mcasas, 2016-07-23 02:33:05]

Patchset #1 (id:120001) has been deleted

[mcasas, 2016-07-23 02:33:53]

Patchset #1 (id:120001) has been deleted

[mcasas, 2016-07-23 02:34:44]

Patchset #1 (id:150001) has been deleted

[mcasas, 2016-07-23 03:30:14]

Patchset #1 (id:170001) has been deleted

[mcasas, 2016-07-25 15:19:15]

Patchset #1 (id:190001) has been deleted

[mcasas, 2016-07-25 15:20:07]

Description was changed from

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) as that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) as that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-25 17:16:01]

Patchset #1 (id:210001) has been deleted

[mcasas, 2016-07-25 17:21:08]

Patchset #1 (id:230001) has been deleted

[mcasas, 2016-07-25 17:23:08]

Description was changed from

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) as that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-25 20:44:25]

Patchset #1 (id:250001) has been deleted

[mcasas, 2016-07-25 21:29:35]

Description was changed from

==========
[wip] Geolocation: move from content/browser to device/


- all of content/browser/geolocation is moved to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 device_unittests
- fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn and
 geolocation.gyp added as well
- geolocation is now a component (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn 
 and geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-25 21:30:46]

mcasas@chromium.org changed reviewers:
+ jam@chromium.org

[mcasas, 2016-07-25 21:30:48]

jam@ PTAL


(I 'm still chasing some specific calls to 
RegisterGeolocationJni for some tests, but 
let's start this review anyway).

[jam, 2016-07-25 22:29:22]

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/access_token_store.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/access_token_store.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
the content/public split is done because content/ is so large. however there
seems to be little benefit to having a public/cpp directory for each
device/service, especially since eventually the public/ part will just be the
mojo interface.

is your intent that first you'll do a simple move, and then in follow-up changes
remove the interfaces and use the concrete types directly?

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/geolocation_service_context.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/geolocation_service_context.h:18: // associated
with a given context. Notably, allows pausing and resuming
this class is browser-context (i.e. profile) specific. does it make sense to
move it to device/geolocation instead of just leaving it in content/?

[mcasas, 2016-07-25 22:33:04]

Patchset #2 (id:290001) has been deleted

[mcasas, 2016-07-26 00:16:09]

Patchset #2 (id:310001) has been deleted

[mcasas, 2016-07-26 00:17:24]

PTAL

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/access_token_store.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/access_token_store.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/07/25 22:29:21, jam wrote:
> the content/public split is done because content/ is so large. however there
> seems to be little benefit to having a public/cpp directory for each
> device/service, especially since eventually the public/ part will just be the
> mojo interface.
> 
> is your intent that first you'll do a simple move, and then in follow-up
changes
> remove the interfaces and use the concrete types directly?

I'd like to do so indeed, especially since this patch
is already quite large, I'd rather be as little
creative as possible :)

Next step I'd like to bring the mojom file(s)
to device/geolocation etc.

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/geolocation_service_context.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/geolocation_service_context.h:18: // associated
with a given context. Notably, allows pausing and resuming
On 2016/07/25 22:29:21, jam wrote:
> this class is browser-context (i.e. profile) specific. does it make sense to
> move it to device/geolocation instead of just leaving it in content/?

Probably not at this point, but it depends
on other geolocation-specific data types, i.e. 
(l.14-15) Geoposition and GeolocationServiceImpl,
where the latter is not exported... WDYT?

Also, I presume this guy might as well go
together with the .mojom, so the closer it
is to the final device/geolocation/public,
the better, correct?

[mcasas, 2016-07-26 01:22:55]

Patchset #2 (id:330001) has been deleted

[mcasas, 2016-07-26 01:52:19]

Patchset #2 (id:350001) has been deleted

[mcasas, 2016-07-26 02:30:30]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 02:30:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 02:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:45:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[jam, 2016-07-26 17:21:29]

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/access_token_store.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/access_token_store.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/07/26 00:17:23, mcasas wrote:
> On 2016/07/25 22:29:21, jam wrote:
> > the content/public split is done because content/ is so large. however there
> > seems to be little benefit to having a public/cpp directory for each
> > device/service, especially since eventually the public/ part will just be
the
> > mojo interface.
> > 
> > is your intent that first you'll do a simple move, and then in follow-up
> changes
> > remove the interfaces and use the concrete types directly?
> 
> I'd like to do so indeed, especially since this patch
> is already quite large, I'd rather be as little
> creative as possible :)

sure makes sense. in that case though, what's the point of temporarily making a
public/cpp/ subdirectory since these files will be removed?

> 
> Next step I'd like to bring the mojom file(s)
> to device/geolocation etc.

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/geolocation_service_context.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/geolocation_service_context.h:18: // associated
with a given context. Notably, allows pausing and resuming
ok so on second thoughts, looking at how this is used by other classes that are
moving, it seems that we'll need something like it regardless to maintain the
current behavior. so moving it now seems fine and we can figure out how to maybe
simplify it later.

[mcasas, 2016-07-26 17:45:32]

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/access_token_store.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/access_token_store.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/07/26 17:21:29, jam wrote:
> On 2016/07/26 00:17:23, mcasas wrote:
> > On 2016/07/25 22:29:21, jam wrote:
> > > the content/public split is done because content/ is so large. however
there
> > > seems to be little benefit to having a public/cpp directory for each
> > > device/service, especially since eventually the public/ part will just be
> the
> > > mojo interface.
> > > 
> > > is your intent that first you'll do a simple move, and then in follow-up
> > changes
> > > remove the interfaces and use the concrete types directly?
> > 
> > I'd like to do so indeed, especially since this patch
> > is already quite large, I'd rather be as little
> > creative as possible :)
> 
> sure makes sense. in that case though, what's the point of temporarily making
a
> public/cpp/ subdirectory since these files will be removed?
> 
> > 
> > Next step I'd like to bring the mojom file(s)
> > to device/geolocation etc.
> 

Not all of them are that  easily removed, i.e. the remaining 
public/cpp files:
- access_token_store.h
- geolocation_delegate.h
- geolocation_provider.h
- geoposition.h
- location_provider.h
are needed by the current embedders, e.g.
blimp_location_provider.h, cast_access_token_store.h
etc, so in a way, they are part of the "public" API of 
Geolocation, right?

Ideally, IIUC, these data types should be generated
out of a mojom interface definition, is that your concern?
(If so, that might possibly be stuff for follow up CLs).

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/geolocation_service_context.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/geolocation_service_context.h:18: // associated
with a given context. Notably, allows pausing and resuming
On 2016/07/26 17:21:29, jam wrote:
> ok so on second thoughts, looking at how this is used by other classes that
are
> moving, it seems that we'll need something like it regardless to maintain the
> current behavior. so moving it now seems fine and we can figure out how to
maybe
> simplify it later.

Acknowledged.

[mcasas, 2016-07-26 18:50:18]

Patchset #2 (id:210002) has been deleted

[jam, 2016-07-26 19:27:27]

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/access_token_store.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/access_token_store.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/07/26 17:45:32, mcasas wrote:
> On 2016/07/26 17:21:29, jam wrote:
> > On 2016/07/26 00:17:23, mcasas wrote:
> > > On 2016/07/25 22:29:21, jam wrote:
> > > > the content/public split is done because content/ is so large. however
> there
> > > > seems to be little benefit to having a public/cpp directory for each
> > > > device/service, especially since eventually the public/ part will just
be
> > the
> > > > mojo interface.
> > > > 
> > > > is your intent that first you'll do a simple move, and then in follow-up
> > > changes
> > > > remove the interfaces and use the concrete types directly?
> > > 
> > > I'd like to do so indeed, especially since this patch
> > > is already quite large, I'd rather be as little
> > > creative as possible :)
> > 
> > sure makes sense. in that case though, what's the point of temporarily
making
> a
> > public/cpp/ subdirectory since these files will be removed?
> > 
> > > 
> > > Next step I'd like to bring the mojom file(s)
> > > to device/geolocation etc.
> > 
> 
> Not all of them are that  easily removed, i.e. the remaining 
> public/cpp files:
> - access_token_store.h
> - geolocation_delegate.h
> - geolocation_provider.h
> - geoposition.h
> - location_provider.h
> are needed by the current embedders, e.g.
> blimp_location_provider.h, cast_access_token_store.h
> etc, so in a way, they are part of the "public" API of 
> Geolocation, right?

Sorry if I'm not clear.

What I mean is that, we don't need interfaces around the implementation classes.
i.e. the code in content, bimp etc can directly include and use the
implementation class. no need to go through interfaces.

> 
> Ideally, IIUC, these data types should be generated
> out of a mojom interface definition, is that your concern?
> (If so, that might possibly be stuff for follow up CLs).

[mcasas, 2016-07-26 21:22:26]

Patchset #2 (id:380001) has been deleted

[mcasas, 2016-07-26 22:34:28]

Patchset #2 (id:400001) has been deleted

[mcasas, 2016-07-26 22:42:35]

PTAL, PS2 removes //device/geolocation/public/cpp
and gets a few more bots green.

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
File device/geolocation/public/cpp/access_token_store.h (right):

https://codereview.chromium.org/2176753003/diff/270001/device/geolocation/pub...
device/geolocation/public/cpp/access_token_store.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/07/26 19:27:27, jam wrote:
> On 2016/07/26 17:45:32, mcasas wrote:
> > On 2016/07/26 17:21:29, jam wrote:
> > > On 2016/07/26 00:17:23, mcasas wrote:
> > > > On 2016/07/25 22:29:21, jam wrote:
> > > > > the content/public split is done because content/ is so large. however
> > there
> > > > > seems to be little benefit to having a public/cpp directory for each
> > > > > device/service, especially since eventually the public/ part will just
> be
> > > the
> > > > > mojo interface.
> > > > > 
> > > > > is your intent that first you'll do a simple move, and then in
follow-up
> > > > changes
> > > > > remove the interfaces and use the concrete types directly?
> > > > 
> > > > I'd like to do so indeed, especially since this patch
> > > > is already quite large, I'd rather be as little
> > > > creative as possible :)
> > > 
> > > sure makes sense. in that case though, what's the point of temporarily
> making
> > a
> > > public/cpp/ subdirectory since these files will be removed?
> > > 
> > > > 
> > > > Next step I'd like to bring the mojom file(s)
> > > > to device/geolocation etc.
> > > 
> > 
> > Not all of them are that  easily removed, i.e. the remaining 
> > public/cpp files:
> > - access_token_store.h
> > - geolocation_delegate.h
> > - geolocation_provider.h
> > - geoposition.h
> > - location_provider.h
> > are needed by the current embedders, e.g.
> > blimp_location_provider.h, cast_access_token_store.h
> > etc, so in a way, they are part of the "public" API of 
> > Geolocation, right?
> 
> Sorry if I'm not clear.
> 
> What I mean is that, we don't need interfaces around the implementation
classes.
> i.e. the code in content, bimp etc can directly include and use the
> implementation class. no need to go through interfaces.
> 
> > 
> > Ideally, IIUC, these data types should be generated
> > out of a mojom interface definition, is that your concern?
> > (If so, that might possibly be stuff for follow up CLs).
> 

Understood! Removed device/geolocation/public/cpp
and the files transported to device/geolocation,
with the corresponding swirl of gn, gyp and DEPS 
files updates.

[jam, 2016-07-26 23:34:33]

lgtm

https://codereview.chromium.org/2176753003/diff/420001/chromeos/geolocation/DEPS
File chromeos/geolocation/DEPS (right):

https://codereview.chromium.org/2176753003/diff/420001/chromeos/geolocation/D...
chromeos/geolocation/DEPS:3: "+device/geolocation",
nit: order

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/DEPS
File device/geolocation/DEPS (right):

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/DEP...
device/geolocation/DEPS:7: "+device/geolocation",
nit: not needed

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/OWNERS
File device/geolocation/OWNERS (right):

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/OWN...
device/geolocation/OWNERS:1: mvanouwerkerk@chromium.org
I'd say also add yourself since you've been doing a lot of work here and you're
making it self contained

[mcasas, 2016-07-27 00:27:33]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 00:32:29]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mcasas, 2016-07-27 01:15:30]

Patchset #4 (id:460001) has been deleted

[mcasas, 2016-07-27 01:16:35]

Patchset #3 (id:440001) has been deleted

[mcasas, 2016-07-27 01:41:13]

Patchset #3 (id:480001) has been deleted

[mcasas, 2016-07-27 01:42:38]

Description was changed from

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation/public/cpp
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn, public/cpp/BUILD.gn 
 and geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and 
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-07-27 01:55:47]

Patchset #3 (id:500001) has been deleted

[mcasas, 2016-07-27 03:12:20]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:12:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 03:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 03:27:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[mcasas, 2016-07-27 06:38:17]

https://codereview.chromium.org/2176753003/diff/420001/chromeos/geolocation/DEPS
File chromeos/geolocation/DEPS (right):

https://codereview.chromium.org/2176753003/diff/420001/chromeos/geolocation/D...
chromeos/geolocation/DEPS:3: "+device/geolocation",
On 2016/07/26 23:34:33, jam wrote:
> nit: order

Done.

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/DEPS
File device/geolocation/DEPS (right):

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/DEP...
device/geolocation/DEPS:7: "+device/geolocation",
On 2016/07/26 23:34:33, jam wrote:
> nit: not needed

Done.

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/OWNERS
File device/geolocation/OWNERS (right):

https://codereview.chromium.org/2176753003/diff/420001/device/geolocation/OWN...
device/geolocation/OWNERS:1: mvanouwerkerk@chromium.org
On 2016/07/26 23:34:33, jam wrote:
> I'd say also add yourself since you've been doing a lot of work here and
you're
> making it self contained

Done.

[mcasas, 2016-07-27 06:42:59]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:43:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 06:53:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 06:53:27]

Dry run: Try jobs failed on following builders:
  win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp...)

[mcasas, 2016-07-27 13:02:16]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 13:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 13:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 13:16:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[mcasas, 2016-07-27 14:07:27]

Patchset #3 (id:520001) has been deleted

[mcasas, 2016-07-27 14:08:28]

Patchset #3 (id:540001) has been deleted

[mcasas, 2016-07-27 14:25:50]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2016-07-27 14:25:50]

Patchset #3 (id:560001) has been deleted

[commit-bot: I haz the power, 2016-07-27 14:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:40:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:40:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mcasas, 2016-07-27 16:29:05]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-07-27 16:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2176753003/#ps580001
(title: "jam@s comments and rebase (mostly blimp/engine)")

[commit-bot: I haz the power, 2016-07-27 16:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 16:39:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 16:39:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mcasas, 2016-07-27 16:47:04]

Description was changed from

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and 
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and 
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers 
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
==========

[mcasas, 2016-07-27 16:47:40]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-07-27 16:48:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 17:07:42]

Description was changed from

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and 
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers 
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
==========

to

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and 
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers 
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
==========

[commit-bot: I haz the power, 2016-07-27 17:07:46]

Committed patchset #3 (id:580001)

[commit-bot: I haz the power, 2016-07-27 17:09:05]

Description was changed from

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into 
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and 
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace. 

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks: 
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.



BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers 
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
==========

to

==========
Geolocation: move from content/browser to device/

This CL:

- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
 are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
 (already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn  and
 geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
 adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
 geolocation_jni_registrar is added.
- classes are moved to device namespace.

All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.

Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
 task runner is cached on constructor and used for both thread
 checking and PostTask()ing (a few unittest and wifi_data_provider*
 needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
 be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.

BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

TBR=pstew@chromium.org
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).

Committed: https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b
Cr-Commit-Position: refs/heads/master@{#408160}
==========

[commit-bot: I haz the power, 2016-07-27 17:09:09]

Patchset 3 (id:??) landed as
https://crrev.com/822d05507b47dffc998a77e30e9f46c9c070045b
Cr-Commit-Position: refs/heads/master@{#408160}

[robliao, 2016-07-27 17:56:21]

A revert of this CL (patchset #3 id:580001) has been created in
https://codereview.chromium.org/2191613002/ by robliao@chromium.org.

The reason for reverting is: Failed on a MSVC build

e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(12): error
C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(12): warning
C4273: 'device::GeolocationDelegate::UseNetworkLocationProviders': inconsistent
dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.h(25): note: see
previous definition of 'UseNetworkLocationProviders'
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(16): warning
C4273: 'device::GeolocationDelegate::CreateAccessTokenStore': inconsistent dll
linkage
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.h(28): note: see
previous definition of 'CreateAccessTokenStore'
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.cc(21): warning
C4273: 'device::GeolocationDelegate::OverrideSystemLocationProvider':
inconsistent dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\geolocation_delegate.h(34): note: see
previous definition of 'OverrideSystemLocationProvider'
[210/2191] CXX
obj\third_party\WebKit\Source\platform\graphics\paint\blink_platform.Transform3DDisplayItem.obj.

[mcasas, 2016-07-27 17:56:58]

A revert of this CL (patchset #3 id:580001) has been created in
https://codereview.chromium.org/2181183004/ by mcasas@chromium.org.

The reason for reverting is: broke win8 bot

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...


FAILED: obj/device/geolocation/device_geolocation.wifi_data_provider_win.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe"
/nologo /showIncludes /FC
@obj\device\geolocation\device_geolocation.wifi_data_provider_win.obj.rsp /c
..\..\device\geolocation\wifi_data_provider_win.cc
/Foobj\device\geolocation\device_geolocation.wifi_data_provider_win.obj
/Fdobj\device\geolocation\device_geolocation.cc.pdb 
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.cc(164): error
C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.cc(164): warning
C4273: 'device::WifiDataProviderManager::DefaultFactoryFunction': inconsistent
dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_manager.h(79): note:
see previous definition of 'DefaultFactoryFunction'
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.cc(168): warning
C4273: 'device::WifiDataProviderWin::WifiDataProviderWin': inconsistent dll
linkage
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.h(17): note: see
previous definition of '{ctor}'
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.cc(171): warning
C4273: 'device::WifiDataProviderWin::~WifiDataProviderWin': inconsistent dll
linkage
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.h(20): note: see
previous definition of '{dtor}'
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.cc(174): warning
C4273: 'device::WifiDataProviderWin::NewWlanApi': inconsistent dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.h(23): note: see
previous definition of 'NewWlanApi'
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.cc(184): warning
C4273: 'device::WifiDataProviderWin::NewPollingPolicy': inconsistent dll linkage
e:\b\c\b\win_gyp\src\device\geolocation\wifi_data_provider_win.h(24): note: see
previous definition of 'NewPollingPolicy'
[148/2191] CXX
obj\device\geolocation\device_geolocation.wifi_data_provider_manager.obj.