Geolocation: move from content/browser to device/

device/geolocation/public/cpp/geolocation_service_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_GEOLOCATION_GEOLOCATION_SERVICE_CONTEXT_H_
-#define CONTENT_BROWSER_GEOLOCATION_GEOLOCATION_SERVICE_CONTEXT_H_
+#ifndef DEVICE_GEOLOCATION_PUBLIC_CPP_GEOLOCATION_SERVICE_CONTEXT_H_
+#define DEVICE_GEOLOCATION_PUBLIC_CPP_GEOLOCATION_SERVICE_CONTEXT_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
-#include "content/browser/geolocation/geolocation_service_impl.h"
 #include "third_party/WebKit/public/platform/modules/geolocation/geolocation.mojom.h"
 
-namespace content {
+namespace device {
+
+class GeolocationServiceImpl;
+struct Geoposition;
 
 // Provides information to a set of GeolocationServiceImpl instances that are
 // associated with a given context. Notably, allows pausing and resuming

[jam, 2016/07/25 22:29:21]

this class is browser-context (i.e. profile) specific. does it make sense to
move it to device/geolocation instead of just leaving it in content/?

[mcasas, 2016/07/26 00:17:23]

Probably not at this point, but it depends
on other geolocation-specific data types, i.e. 
(l.14-15) Geoposition and GeolocationServiceImpl,
where the latter is not exported... WDYT?

Also, I presume this guy might as well go
together with the .mojom, so the closer it
is to the final device/geolocation/public,
the better, correct?

[jam, 2016/07/26 17:21:29]

ok so on second thoughts, looking at how this is used by other classes that are
moving, it seems that we'll need something like it regardless to maintain the
current behavior. so moving it now seems fine and we can figure out how to maybe
simplify it later.

[mcasas, 2016/07/26 17:45:32]

Acknowledged.

 // geolocation on these instances.
 class GeolocationServiceContext {
  public:
   GeolocationServiceContext();
   virtual ~GeolocationServiceContext();
 
   // Creates a GeolocationServiceImpl that is weakly bound to |request|.
   // |update_callback| will be called when services send
   // location updates to their clients.
   void CreateService(
@@ skipping 22 matching lines @@
 
  private:
   ScopedVector<GeolocationServiceImpl> services_;
   bool paused_;
 
   std::unique_ptr<Geoposition> geoposition_override_;
 
   DISALLOW_COPY_AND_ASSIGN(GeolocationServiceContext);
 };
 
-}  // namespace content
+}  // namespace device
 
-#endif  // CONTENT_BROWSER_GEOLOCATION_GEOLOCATION_SERVICE_CONTEXT_H_
+#endif  // DEVICE_GEOLOCATION_PUBLIC_CPP_GEOLOCATION_SERVICE_CONTEXT_H_