Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2176693002: Fix crash when process APK log without offset (Closed)

Created:
4 years, 5 months ago by michaelbai
Modified:
4 years, 5 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when process APK log without offset Found crash in apk, but there is no offset, like below DEBUG : #04 pc 0000000000209998 /data/app/org.chromium.chrome-1/base.apk BUG=630620 Committed: https://crrev.com/72424435fd121181d152f44265fa55a74bb931e3 Cr-Commit-Position: refs/heads/master@{#407172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/android_platform/development/scripts/stack_core.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
michaelbai
4 years, 5 months ago (2016-07-22 15:34:04 UTC) #3
sgurun-gerrit only
lgtm
4 years, 5 months ago (2016-07-22 15:37:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176693002/1
4 years, 5 months ago (2016-07-22 15:44:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 16:32:21 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 16:34:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72424435fd121181d152f44265fa55a74bb931e3
Cr-Commit-Position: refs/heads/master@{#407172}

Powered by Google App Engine
This is Rietveld 408576698