third_party/android_platform/development/scripts/stack_core.py - Issue 2176693002: Fix crash when process APK log without offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_platform/development/scripts/stack_core.py

Issue 2176693002: Fix crash when process APK log without offset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/android_platform/development/scripts/stack_core.py

diff --git a/third_party/android_platform/development/scripts/stack_core.py b/third_party/android_platform/development/scripts/stack_core.py

index 1dceb2ef66b795b236b8c2f0f9914454622a61c2..119bd407009ed0749b0c4d59effd413793831cae 100755

--- a/third_party/android_platform/development/scripts/stack_core.py

+++ b/third_party/android_platform/development/scripts/stack_core.py

@@ -273,7 +273,7 @@ class PreProcessLog:

match = _TRACE_LINE.match(line)

if match:

lib, symbol_present = match.group('lib', 'symbol_present')

- if os.path.splitext(lib)[1] == '.apk':

+ if os.path.splitext(lib)[1] == '.apk' and symbol_present:

soname = self._DetectSharedLibrary(lib, symbol_present)

if soname:

line = line.replace('/' + os.path.basename(lib), '/' + soname)

« no previous file with comments | « no previous file | no next file » | no next file with comments »