Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
index df2c79a3ea576ee4150772475d986bb995145df9..a2824eaaf81ba5707a93e2b2157a9fe9bbdb4598 100644
--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
@@ -540,13 +540,14 @@ TEST_F(MediaRouterWebUIMessageHandlerTest,
TEST_F(MediaRouterWebUIMessageHandlerTest, UpdateIssue) {
std::string issue_title("An issue");
std::string issue_message("This is an issue");
- IssueAction default_action(IssueAction::TYPE_LEARN_MORE);
- std::vector<IssueAction> secondary_actions;
- secondary_actions.push_back(IssueAction(IssueAction::TYPE_DISMISS));
+ Issue::ActionType default_action = Issue::ActionType::LEARN_MORE;
+ std::vector<Issue::ActionType> secondary_actions;
+ secondary_actions.push_back(Issue::ActionType::DISMISS);
MediaRoute::Id route_id("routeId123");
- bool is_blocking = true;
- Issue issue(issue_title, issue_message, default_action, secondary_actions,
- route_id, Issue::FATAL, is_blocking, -1);
+ Issue issue(issue_title, default_action, Issue::Severity::FATAL);
+ issue.set_message(issue_message);
+ issue.set_secondary_actions(secondary_actions);
+ issue.set_route_id(route_id);
const Issue::Id& issue_id = issue.id();
handler_->UpdateIssue(&issue);
@@ -557,9 +558,10 @@ TEST_F(MediaRouterWebUIMessageHandlerTest, UpdateIssue) {
const base::DictionaryValue* issue_value = nullptr;
ASSERT_TRUE(arg1->GetAsDictionary(&issue_value));
+ int actual_issue_id = -1;
std::string value;
- EXPECT_TRUE(issue_value->GetString("id", &value));
- EXPECT_EQ(issue_id, value);
+ EXPECT_TRUE(issue_value->GetInteger("id", &actual_issue_id));
+ EXPECT_EQ(issue_id, actual_issue_id);
EXPECT_TRUE(issue_value->GetString("title", &value));
EXPECT_EQ(issue_title, value);
EXPECT_TRUE(issue_value->GetString("message", &value));
@@ -567,16 +569,17 @@ TEST_F(MediaRouterWebUIMessageHandlerTest, UpdateIssue) {
int action_type_num = -1;
EXPECT_TRUE(issue_value->GetInteger("defaultActionType", &action_type_num));
- EXPECT_EQ(default_action.type(), action_type_num);
+ EXPECT_EQ(static_cast<int>(default_action), action_type_num);
EXPECT_TRUE(issue_value->GetInteger("secondaryActionType", &action_type_num));
- EXPECT_EQ(secondary_actions[0].type(), action_type_num);
+ EXPECT_EQ(static_cast<int>(secondary_actions[0]), action_type_num);
EXPECT_TRUE(issue_value->GetString("routeId", &value));
EXPECT_EQ(route_id, value);
+ // The issue is blocking since it is FATAL.
bool actual_is_blocking = false;
EXPECT_TRUE(issue_value->GetBoolean("isBlocking", &actual_is_blocking));
- EXPECT_EQ(is_blocking, actual_is_blocking);
+ EXPECT_TRUE(actual_is_blocking);
}
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698