Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
index c75b3c73da27b2145ac17b1ce200eb6f5f04027d..021ba8aa9a9edc8a62406347d59ffcdc03417c84 100644
--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
@@ -188,17 +188,18 @@ std::unique_ptr<base::ListValue> CastModesToValue(
// Returns an Issue dictionary created from |issue| that can be used in WebUI.
std::unique_ptr<base::DictionaryValue> IssueToValue(const Issue& issue) {
std::unique_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);
- dictionary->SetString("id", issue.id());
+ dictionary->SetInteger("id", issue.id());
dictionary->SetString("title", issue.title());
dictionary->SetString("message", issue.message());
- dictionary->SetInteger("defaultActionType", issue.default_action().type());
+ dictionary->SetInteger("defaultActionType",
+ static_cast<int>(issue.default_action()));
if (!issue.secondary_actions().empty()) {
dictionary->SetInteger("secondaryActionType",
- issue.secondary_actions().begin()->type());
+ static_cast<int>(issue.secondary_actions()[0]));
}
if (!issue.route_id().empty())
dictionary->SetString("routeId", issue.route_id());
- dictionary->SetBoolean("isBlocking", issue.is_blocking());
+ dictionary->SetBoolean("isBlocking", issue.IsBlocking());
if (issue.help_page_id() > 0)
dictionary->SetInteger("helpPageId", issue.help_page_id());
@@ -207,7 +208,7 @@ std::unique_ptr<base::DictionaryValue> IssueToValue(const Issue& issue) {
bool IsValidIssueActionTypeNum(int issue_action_type_num) {
return issue_action_type_num >= 0 &&
- issue_action_type_num < IssueAction::TYPE_MAX;
+ issue_action_type_num < static_cast<int>(Issue::ActionType::MAX);
}
// Composes a "learn more" URL. The URL depends on template arguments in |args|.
@@ -454,11 +455,8 @@ void MediaRouterWebUIMessageHandler::OnCreateRoute(
static_cast<MediaRouterUI*>(web_ui()->GetController());
if (media_router_ui->HasPendingRouteRequest()) {
DVLOG(1) << "UI already has pending route request. Ignoring.";
- Issue issue(
- l10n_util::GetStringUTF8(IDS_MEDIA_ROUTER_ISSUE_PENDING_ROUTE),
- std::string(), IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), std::string(), Issue::NOTIFICATION,
- false, -1);
+ Issue issue(l10n_util::GetStringUTF8(IDS_MEDIA_ROUTER_ISSUE_PENDING_ROUTE),
+ Issue::ActionType::DISMISS, Issue::Severity::NOTIFICATION);
media_router_ui_->AddIssue(issue);
return;
}
@@ -503,7 +501,7 @@ void MediaRouterWebUIMessageHandler::OnActOnIssue(
Issue::Id issue_id;
int action_type_num = -1;
if (!args->GetDictionary(0, &args_dict) ||
- !args_dict->GetString("issueId", &issue_id) ||
+ !args_dict->GetInteger("issueId", &issue_id) ||
!args_dict->GetInteger("actionType", &action_type_num)) {
DVLOG(1) << "Unable to extract args.";
return;
@@ -512,8 +510,8 @@ void MediaRouterWebUIMessageHandler::OnActOnIssue(
DVLOG(1) << "Invalid action type: " << action_type_num;
return;
}
- IssueAction::Type action_type =
- static_cast<IssueAction::Type>(action_type_num);
+ Issue::ActionType action_type =
+ static_cast<Issue::ActionType>(action_type_num);
if (ActOnIssueType(action_type, args_dict))
DVLOG(1) << "ActOnIssueType failed for Issue ID " << issue_id;
media_router_ui_->ClearIssue(issue_id);
@@ -547,11 +545,8 @@ void MediaRouterWebUIMessageHandler::OnJoinRoute(const base::ListValue* args) {
static_cast<MediaRouterUI*>(web_ui()->GetController());
if (media_router_ui->HasPendingRouteRequest()) {
DVLOG(1) << "UI already has pending route request. Ignoring.";
- Issue issue(
- l10n_util::GetStringUTF8(IDS_MEDIA_ROUTER_ISSUE_PENDING_ROUTE),
- std::string(), IssueAction(IssueAction::TYPE_DISMISS),
- std::vector<IssueAction>(), std::string(), Issue::NOTIFICATION,
- false, -1);
+ Issue issue(l10n_util::GetStringUTF8(IDS_MEDIA_ROUTER_ISSUE_PENDING_ROUTE),
+ Issue::ActionType::DISMISS, Issue::Severity::NOTIFICATION);
media_router_ui_->AddIssue(issue);
return;
}
@@ -780,9 +775,9 @@ void MediaRouterWebUIMessageHandler::OnInitialDataReceived(
}
bool MediaRouterWebUIMessageHandler::ActOnIssueType(
- const IssueAction::Type& action_type,
+ Issue::ActionType action_type,
const base::DictionaryValue* args) {
- if (action_type == IssueAction::TYPE_LEARN_MORE) {
+ if (action_type == Issue::ActionType::LEARN_MORE) {
std::string learn_more_url = GetLearnMoreUrl(args);
if (learn_more_url.empty())
return false;

Powered by Google App Engine
This is Rietveld 408576698