Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3369)

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 2176613003: [Media Router] Clean up issues related code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
index 5175891ee2be244fbf71666c9173fd01291c49f9..cdd01b6488d6d62564198c48a52aeeeec765f1b3 100644
--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
@@ -31,7 +31,10 @@ namespace media_router {
class MediaRouterUIBrowserTest : public InProcessBrowserTest {
public:
- MediaRouterUIBrowserTest() {}
+ MediaRouterUIBrowserTest()
+ : issue_(IssueInfo("title notification",
+ IssueInfo::Action::DISMISS,
+ IssueInfo::Severity::NOTIFICATION)) {}
~MediaRouterUIBrowserTest() override {}
void SetUpOnMainThread() override {
@@ -47,12 +50,6 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
action_controller_ =
MediaRouterUIService::Get(browser()->profile())->action_controller();
- issue_.reset(new Issue(
- "title notification", "message notification",
- media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),
- std::vector<media_router::IssueAction>(), "route_id",
- media_router::Issue::NOTIFICATION, false, -1));
-
routes_ = {MediaRoute("routeId1", MediaSource("sourceId"), "sinkId1",
"description", true, std::string(), true)};
}
@@ -108,7 +105,7 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
protected:
ToolbarActionsBar* toolbar_actions_bar_ = nullptr;
- std::unique_ptr<Issue> issue_;
+ Issue issue_;
// A vector of MediaRoutes that includes a local route.
std::vector<MediaRoute> routes_;
@@ -150,9 +147,9 @@ IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
EphemeralToolbarIconForRoutesAndIssues) {
- action_controller_->OnIssueUpdated(issue_.get());
+ action_controller_->OnIssue(issue_);
EXPECT_TRUE(ActionExists());
- action_controller_->OnIssueUpdated(nullptr);
+ action_controller_->OnIssuesCleared();
EXPECT_FALSE(ActionExists());
action_controller_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
« no previous file with comments | « chrome/browser/ui/toolbar/media_router_action_unittest.cc ('k') | chrome/browser/ui/webui/media_router/media_router_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698