[Media Router] Clean up issues related code.

chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/media/router/media_router_ui_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 13 matching lines @@
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "ui/views/widget/widget.h"
 
 namespace media_router {
 
 class MediaRouterUIBrowserTest : public InProcessBrowserTest {
  public:
-  MediaRouterUIBrowserTest() {}
+  MediaRouterUIBrowserTest()
+      : issue_(IssueInfo("title notification",
+                         IssueInfo::Action::DISMISS,
+                         IssueInfo::Severity::NOTIFICATION)) {}
   ~MediaRouterUIBrowserTest() override {}
 
   void SetUpOnMainThread() override {
     InProcessBrowserTest::SetUpOnMainThread();
 
     BrowserActionsContainer* browser_actions_container =
         BrowserView::GetBrowserViewForBrowser(browser())
             ->toolbar()
             ->browser_actions();
     ASSERT_TRUE(browser_actions_container);
     toolbar_actions_bar_ = browser_actions_container->toolbar_actions_bar();
 
     action_controller_ =
         MediaRouterUIService::Get(browser()->profile())->action_controller();
 
-    issue_.reset(new Issue(
-        "title notification", "message notification",
-        media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),
-        std::vector<media_router::IssueAction>(), "route_id",
-        media_router::Issue::NOTIFICATION, false, -1));
-
     routes_ = {MediaRoute("routeId1", MediaSource("sourceId"), "sinkId1",
                           "description", true, std::string(), true)};
   }
 
   void OpenMediaRouterDialogAndWaitForNewWebContents() {
     content::TestNavigationObserver nav_observer(NULL);
     nav_observer.StartWatchingNewWebContents();
 
     AppMenuButton* app_menu_button =
         BrowserView::GetBrowserViewForBrowser(browser())
@@ skipping 35 matching lines @@
   void SetAlwaysShowActionPref(bool always_show) {
     return ToolbarActionsModel::Get(browser()->profile())
         ->component_migration_helper()
         ->SetComponentActionPref(
             ComponentToolbarActionsFactory::kMediaRouterActionId, always_show);
   }
 
  protected:
   ToolbarActionsBar* toolbar_actions_bar_ = nullptr;
 
-  std::unique_ptr<Issue> issue_;
+  Issue issue_;
 
   // A vector of MediaRoutes that includes a local route.
   std::vector<MediaRoute> routes_;
 
   MediaRouterActionController* action_controller_ = nullptr;
 };
 
 // TODO(crbug.com/658005): Fails on multiple platforms.
 IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
                        DISABLED_OpenDialogWithMediaRouterAction) {
@@ skipping 21 matching lines @@
 
   // The navigation should have removed the previously created dialog.
   // We expect a new dialog WebContents to be created by calling this.
   OpenMediaRouterDialogAndWaitForNewWebContents();
 
   SetAlwaysShowActionPref(false);
 }
 
 IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
                        EphemeralToolbarIconForRoutesAndIssues) {
-  action_controller_->OnIssueUpdated(issue_.get());
+  action_controller_->OnIssue(issue_);
   EXPECT_TRUE(ActionExists());
-  action_controller_->OnIssueUpdated(nullptr);
+  action_controller_->OnIssuesCleared();
   EXPECT_FALSE(ActionExists());
 
   action_controller_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
   EXPECT_TRUE(ActionExists());
   action_controller_->OnRoutesUpdated(std::vector<MediaRoute>(),
                                       std::vector<MediaRoute::Id>());
   EXPECT_FALSE(ActionExists());
 
   SetAlwaysShowActionPref(true);
   EXPECT_TRUE(ActionExists());
@@ skipping 47 matching lines @@
   action_controller_->OnRoutesUpdated(std::vector<MediaRoute>(),
                                       std::vector<MediaRoute::Id>());
   EXPECT_FALSE(ActionExists());
   action_controller_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
   EXPECT_TRUE(ActionExists());
   browser2->window()->Close();
   EXPECT_TRUE(ActionExists());
 }
 
 }  // namespace media_router