[css-grid] Implementing stretch alignment in orthogonal flows

[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823
Committed: https://crrev.com/e316fd483b282a644bf7d9d05c43399bcf46c6fb
Cr-Commit-Position: refs/heads/master@{#407779}

[jfernandez, 2016-07-22 07:01:16]

Description was changed from

==========
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823
==========

to

==========
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823
==========

[jfernandez, 2016-07-22 07:01:16]

jfernandez@igalia.com changed reviewers:
+ cbiesinger@chromium.org, rego@igalia.com, svillar@igalia.com

[jfernandez, 2016-07-22 07:01:44]

Patch ready for review.

[cbiesinger, 2016-07-22 16:43:52]

lgtm

[cbiesinger, 2016-07-22 16:44:01]

https://codereview.chromium.org/2176533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/2176533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:2202: bool
stretchingAlognColumnAxis = ComputedStyle::resolveAlignment(styleRef(),
childStyle, ItemPositionStretch) == ItemPositionStretch;
Alogn -> Along

[jfernandez, 2016-07-26 10:05:25]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2016-07-26 10:05:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2176533002/#ps20001
(title: "Applied suggested changes.")

[commit-bot: I haz the power, 2016-07-26 10:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 13:01:59]

Description was changed from

==========
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823
==========

to

==========
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823
==========

[commit-bot: I haz the power, 2016-07-26 13:02:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 13:04:28]

Description was changed from

==========
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823
==========

to

==========
[css-grid] Implementing stretch alignment in orthogonal flows

After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.

Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow the
implementation of the stretching logic can be done in a clearer way.

This patch implements the missing logic and performs some refactoring
so it became flow direction independent.

BUG=556171, 445742, 376823

Committed: https://crrev.com/e316fd483b282a644bf7d9d05c43399bcf46c6fb
Cr-Commit-Position: refs/heads/master@{#407779}
==========

[commit-bot: I haz the power, 2016-07-26 13:04:30]

Patchset 2 (id:??) landed as
https://crrev.com/e316fd483b282a644bf7d9d05c43399bcf46c6fb
Cr-Commit-Position: refs/heads/master@{#407779}