Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2176523003: FrameView shouldn't apply scroll anchoring when root layer scrolling is enabled (Closed)

Created:
4 years, 5 months ago by ymalik
Modified:
4 years, 5 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FrameView shouldn't apply scroll anchoring when root layer scrolling is enabled Before this patch, when root layer scrolling was enabled, both FV and PLSA would perform scroll anchoring. FV doesn't need perform scroll anchoring for the main frame because PLSA will do the right thing. This issue was found because the following tests failed when ScrollAnchoring was turned on by default: virtual/rootlayerscrolls/fast/scrolling/scroll-into-view-collapsed-div.html virtual/rootlayerscrolls/fast/scrolling/fractional-scroll-offset-document.html BUG=597479, 558575 Committed: https://crrev.com/4b34e4b56319572e06425dd77e4d3b30d86ce049 Cr-Commit-Position: refs/heads/master@{#407211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
ymalik
4 years, 5 months ago (2016-07-22 14:45:19 UTC) #3
skobes
lgtm
4 years, 5 months ago (2016-07-22 14:53:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176523003/1
4 years, 5 months ago (2016-07-22 16:57:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 18:35:22 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:37:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b34e4b56319572e06425dd77e4d3b30d86ce049
Cr-Commit-Position: refs/heads/master@{#407211}

Powered by Google App Engine
This is Rietveld 408576698