Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2176523003: FrameView shouldn't apply scroll anchoring when root layer scrolling is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 EffectPaintPropertyNode* rootEffect() const { return m_rootEffect.get(); } 610 EffectPaintPropertyNode* rootEffect() const { return m_rootEffect.get(); }
611 611
612 // TODO(ojan): Merge this with IntersectionObserver once it lands. 612 // TODO(ojan): Merge this with IntersectionObserver once it lands.
613 IntRect computeVisibleArea(); 613 IntRect computeVisibleArea();
614 614
615 // Viewport size that should be used for viewport units (i.e. 'vh'/'vw'). 615 // Viewport size that should be used for viewport units (i.e. 'vh'/'vw').
616 FloatSize viewportSizeForViewportUnits() const; 616 FloatSize viewportSizeForViewportUnits() const;
617 617
618 ScrollAnchor& scrollAnchor() { return m_scrollAnchor; } 618 ScrollAnchor& scrollAnchor() { return m_scrollAnchor; }
619 void clearScrollAnchor(); 619 void clearScrollAnchor();
620 bool shouldPerformScrollAnchoring() const override;
620 621
621 // For PaintInvalidator temporarily. TODO(wangxianzhu): Move into PaintInval idator. 622 // For PaintInvalidator temporarily. TODO(wangxianzhu): Move into PaintInval idator.
622 void invalidatePaintIfNeeded(const PaintInvalidationState&); 623 void invalidatePaintIfNeeded(const PaintInvalidationState&);
623 624
624 protected: 625 protected:
625 // Scroll the content via the compositor. 626 // Scroll the content via the compositor.
626 bool scrollContentsFastPath(const IntSize& scrollDelta); 627 bool scrollContentsFastPath(const IntSize& scrollDelta);
627 628
628 // Scroll the content by invalidating everything. 629 // Scroll the content by invalidating everything.
629 void scrollContentsSlowPath(const IntRect& updateRect); 630 void scrollContentsSlowPath(const IntRect& updateRect);
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 964 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
964 setIsVisuallyNonEmpty(); 965 setIsVisuallyNonEmpty();
965 } 966 }
966 967
967 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 968 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
968 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView()); 969 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView());
969 970
970 } // namespace blink 971 } // namespace blink
971 972
972 #endif // FrameView_h 973 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698