Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 2176443002: Add client and host dispatchers for video_stats channel to send video stats from host to client. (Closed)

Created:
3 years, 1 month ago by Sergey Ulanov
Modified:
3 years, 1 month ago
Reviewers:
Irfan, Jamie
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simple_channel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add client and host dispatchers for video_stats channel to send video stats from host to client. The new channel will be used with WebRTC protocol to send video stats to client to make it possible to measure round-trip latency. BUG=621691 Committed: https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25 Cr-Commit-Position: refs/heads/master@{#407221}

Patch Set 1 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -6 lines) Patch
M remoting/base/constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/proto/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/proto/chromotocol.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/proto/video_stats.proto View 1 chunk +42 lines, -0 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.h View 2 chunks +1 line, -5 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
A remoting/protocol/client_video_stats_dispatcher.h View 1 chunk +40 lines, -0 lines 0 comments Download
A remoting/protocol/client_video_stats_dispatcher.cc View 1 chunk +47 lines, -0 lines 2 comments Download
M remoting/protocol/frame_stats.h View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/frame_stats.cc View 2 chunks +70 lines, -0 lines 0 comments Download
A remoting/protocol/host_video_stats_dispatcher.h View 1 chunk +35 lines, -0 lines 0 comments Download
A remoting/protocol/host_video_stats_dispatcher.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A remoting/protocol/video_stats_stub.h View 1 chunk +34 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
Sergey Ulanov
3 years, 1 month ago (2016-07-22 01:03:21 UTC) #2
Jamie
LGTM unless you take my suggestion of a single channel, in which case I'll look ...
3 years, 1 month ago (2016-07-22 17:13:52 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/2176443002/diff/20001/remoting/protocol/client_video_stats_dispatcher.cc File remoting/protocol/client_video_stats_dispatcher.cc (right): https://codereview.chromium.org/2176443002/diff/20001/remoting/protocol/client_video_stats_dispatcher.cc#newcode25 remoting/protocol/client_video_stats_dispatcher.cc:25: : ChannelDispatcherBase(kVideoStatsChannelNamePrefix + stream_name), On 2016/07/22 17:13:52, Jamie wrote: ...
3 years, 1 month ago (2016-07-22 17:47:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176443002/20001
3 years, 1 month ago (2016-07-22 17:48:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 1 month ago (2016-07-22 18:55:01 UTC) #11
commit-bot: I haz the power
3 years, 1 month ago (2016-07-22 18:57:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360f5baebcab5f3e464e52736f5013b2f8293d25
Cr-Commit-Position: refs/heads/master@{#407221}

Powered by Google App Engine
This is Rietveld 408576698