Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2176373002: Don't create zero-velocity GestureFlingStarts. (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Don't create zero-velocity GestureFlingStarts. Currently trackpad initiated GestureFlingStarts on CrOS can have zero- velocity, but this causes crashes in the renderer. This CL converts these events to be GestureFlingCancels (just in case they are issued in the middle of ongoing fling). As it is hard to find the sources of such events after the fact, a DCHECK has been added to catch new pathways if they issue such events. BUG=627227 Review-Url: https://codereview.chromium.org/2165043002 Cr-Commit-Position: refs/heads/master@{#406678} (cherry picked from commit e80690ff28bf6db9392ab9b96a31105e1a6d4205) Committed: https://chromium.googlesource.com/chromium/src/+/1e514f96624ed05d048b7adb87c4a4406be1ad54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
4 years, 5 months ago (2016-07-25 21:15:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e514f96624ed05d048b7adb87c4a4406be1ad54.

Powered by Google App Engine
This is Rietveld 408576698